Differential D19550

Improve Space behavior for subprojects and milestones
ClosedPublic
Actions

Authored by epriestley on Jul 30 2018, 11:01 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, May 10, 10:25 AM

	Unknown Object (File)
	Thu, May 8, 8:58 AM

	Unknown Object (File)
	Sun, Apr 20, 5:15 PM

	Unknown Object (File)
	Sun, Apr 20, 6:01 AM

	Unknown Object (File)
	Sat, Apr 19, 10:38 PM

	Unknown Object (File)
	Apr 17 2025, 12:06 AM

	Unknown Object (File)
	Apr 5 2025, 7:28 PM

	Unknown Object (File)
	Mar 25 2025, 9:17 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13164: Plans: 2018 Week 31 - 33 Bonus Content

Commits

rPd9b5b0495088: Improve Space behavior for subprojects and milestones

Summary

Depends on D19549. Ref T13164. See PHI774.

Make milestones inherit their parent project's space automatically, like they inherit their parent policies.
Make subprojects default to their parent project's space.

Test Plan

Created subprojects and milestones, got sensible default/effective Space behavior.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jul 30 2018, 11:01 PM

Harbormaster completed remote builds in B20540: Diff 46741.Jul 30 2018, 11:02 PM

epriestley requested review of this revision.Jul 30 2018, 11:02 PM

epriestley added a child revision: D19551: Put "Subprojects" on top of "Milestones" in the Project UI.Jul 30 2018, 11:04 PM

amckinley accepted this revision.Jul 30 2018, 11:12 PM

This revision is now accepted and ready to land.Jul 30 2018, 11:12 PM

Closed by commit rPd9b5b0495088: Improve Space behavior for subprojects and milestones (authored by epriestley). · Explain WhyJul 31 2018, 5:22 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T10611: No option to specify a Space when editing a Project's visibility policy.Mar 12 2019, 3:16 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

engine/

PhabricatorProjectEditEngine.php

7 lines

storage/

PhabricatorProject.php

18 lines

Diff 46747

src/applications/project/engine/PhabricatorProjectEditEngine.php

Loading...

src/applications/project/storage/PhabricatorProject.php

Loading...