Make the "Is this JSON?" DocumentEngine heuristic a little tighter
ClosedPublic
Actions

Authored by epriestley on Jul 27 2018, 6:29 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13164: Plans: 2018 Week 31 - 33 Bonus Content

Commits

rPcb99396c64dc: Make the "Is this JSON?" DocumentEngine heuristic a little tighter

Summary

See PHI749. Ref T13164. We currently misdetect files starting with [submodule ... as JSON.

Make this a bit stricter:

If the file is short, just see if it's actually literally real JSON.
If the file is long, give up.

This should get the right result in pretty much all the cases people care about, I think. We could make the long-file guesser better some day.

Test Plan

Detected a [submodule ... file (no longer JSON) and a {"duck": "quack"} file (still JSON).

Diff Detail

Repository

rP Phabricator

Branch

json1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20522
Build 27871: Run Core Tests
Build 27870: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 27 2018, 6:29 PM

Harbormaster completed remote builds in B20522: Diff 46725.Jul 27 2018, 6:30 PM

epriestley requested review of this revision.Jul 27 2018, 6:30 PM

amckinley accepted this revision.Jul 27 2018, 6:43 PM

This revision is now accepted and ready to land.Jul 27 2018, 6:43 PM

Closed by commit rPcb99396c64dc: Make the "Is this JSON?" DocumentEngine heuristic a little tighter (authored by epriestley). · Explain WhyJul 27 2018, 7:27 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

files/

document/

PhabricatorDocumentRef.php

16 lines

Diff 46725

View Options

src/applications/files/document/PhabricatorDocumentRef.php

Make the "Is this JSON?" DocumentEngine heuristic a little tighterClosedPublicActions