Page MenuHomePhabricator

Make the "Is this JSON?" DocumentEngine heuristic a little tighter
ClosedPublic

Authored by epriestley on Jul 27 2018, 6:29 PM.
Tags
None
Referenced Files
F15443942: D19544.id.diff
Thu, Mar 27, 6:59 AM
F15439789: D19544.diff
Wed, Mar 26, 9:29 AM
F15431692: D19544.id46725.diff
Mon, Mar 24, 1:58 PM
F15398684: D19544.id46726.diff
Mon, Mar 17, 1:14 AM
Unknown Object (File)
Mar 3 2025, 1:28 AM
Unknown Object (File)
Feb 9 2025, 6:12 AM
Unknown Object (File)
Feb 9 2025, 6:12 AM
Unknown Object (File)
Feb 9 2025, 6:12 AM
Subscribers
None

Details

Summary

See PHI749. Ref T13164. We currently misdetect files starting with [submodule ... as JSON.

Make this a bit stricter:

  • If the file is short, just see if it's actually literally real JSON.
  • If the file is long, give up.

This should get the right result in pretty much all the cases people care about, I think. We could make the long-file guesser better some day.

Test Plan

Detected a [submodule ... file (no longer JSON) and a {"duck": "quack"} file (still JSON).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable