Page MenuHomePhabricator

Make the "Is this JSON?" DocumentEngine heuristic a little tighter
ClosedPublic

Authored by epriestley on Jul 27 2018, 6:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 16, 4:54 PM
Unknown Object (File)
Sun, Mar 10, 5:58 AM
Unknown Object (File)
Fri, Mar 1, 4:09 PM
Unknown Object (File)
Feb 17 2024, 4:10 AM
Unknown Object (File)
Feb 8 2024, 2:08 PM
Unknown Object (File)
Jan 27 2024, 5:03 PM
Unknown Object (File)
Jan 7 2024, 5:30 PM
Unknown Object (File)
Jan 3 2024, 6:05 PM
Subscribers
None

Details

Summary

See PHI749. Ref T13164. We currently misdetect files starting with [submodule ... as JSON.

Make this a bit stricter:

  • If the file is short, just see if it's actually literally real JSON.
  • If the file is long, give up.

This should get the right result in pretty much all the cases people care about, I think. We could make the long-file guesser better some day.

Test Plan

Detected a [submodule ... file (no longer JSON) and a {"duck": "quack"} file (still JSON).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable