Page MenuHomePhabricator

Respect "metamta.email-body-limit" when building mail HTML bodies
ClosedPublic

Authored by epriestley on Jun 12 2018, 5:01 PM.
Tags
None
Referenced Files
F12838669: D19489.id46612.diff
Thu, Mar 28, 6:28 PM
Unknown Object (File)
Dec 24 2023, 4:52 PM
Unknown Object (File)
Dec 22 2023, 1:36 AM
Unknown Object (File)
Nov 30 2023, 12:58 AM
Unknown Object (File)
Nov 24 2023, 10:24 PM
Unknown Object (File)
Nov 15 2023, 7:13 PM
Unknown Object (File)
Nov 15 2023, 11:17 AM
Unknown Object (File)
Nov 12 2023, 8:18 PM
Subscribers
None

Details

Summary

Ref T13151. See T11767. See PHI686. Although we limit outbound mail text bodies, the limit doesn't currently apply to attachments, HTML bodies, or headers. T11767 discusses improving this in the general case.

In the wild, an install hit an issue (see PHI686) where edits to Phriction pages generate very large HTML bodies. Check and respect the limit when building HTML bodies.

If we don't have enough room for the HTML body, we just drop it. We have the text body to fall back to, and HTML is difficult to truncate safely.

Test Plan

Added unit tests and made them pass.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable