Page MenuHomePhabricator

Respect "metamta.email-body-limit" when building mail HTML bodies
ClosedPublic

Authored by epriestley on Jun 12 2018, 5:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 25, 3:15 AM
Unknown Object (File)
Thu, Oct 24, 2:17 PM
Unknown Object (File)
Oct 14 2024, 9:06 PM
Unknown Object (File)
Oct 13 2024, 2:41 PM
Unknown Object (File)
Oct 13 2024, 7:06 AM
Unknown Object (File)
Oct 9 2024, 9:41 AM
Unknown Object (File)
Oct 7 2024, 7:11 PM
Unknown Object (File)
Sep 6 2024, 3:29 AM
Subscribers
None

Details

Summary

Ref T13151. See T11767. See PHI686. Although we limit outbound mail text bodies, the limit doesn't currently apply to attachments, HTML bodies, or headers. T11767 discusses improving this in the general case.

In the wild, an install hit an issue (see PHI686) where edits to Phriction pages generate very large HTML bodies. Check and respect the limit when building HTML bodies.

If we don't have enough room for the HTML body, we just drop it. We have the text body to fall back to, and HTML is difficult to truncate safely.

Test Plan

Added unit tests and made them pass.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable