Page MenuHomePhabricator

Allow encrypted mail to be more specific about which object is affected
ClosedPublic

Authored by epriestley on Jun 12 2018, 3:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 11:50 PM
Unknown Object (File)
Sat, Dec 7, 5:48 AM
Unknown Object (File)
Dec 3 2024, 11:20 AM
Unknown Object (File)
Nov 27 2024, 12:29 PM
Unknown Object (File)
Nov 25 2024, 9:47 PM
Unknown Object (File)
Nov 20 2024, 11:36 AM
Unknown Object (File)
Nov 18 2024, 1:33 AM
Unknown Object (File)
Nov 15 2024, 4:57 PM
Subscribers
None

Details

Summary

Depends on D19487. Ref T13151. See PHI647. For some objects, like revisions, we can build slightly more useful secure email without actually disclosing anything.

In the general case, the object monogram may disclose information (#acquire-competitor) but most do not, so applications can whitelist an acceptable nondisclosing subject and link.

Support doing this, and make Differential do it. When we don't have a whitelisted URI but do know the object the mail is about, include a generic PHID-based URI; these are always nondisclosing.

Test Plan
  • Without the Differential changes, sent normal mail (no changes) and secure mail (new generic PHID-based link).
  • With the Differential changes, sent secure mail; got richer subject and body link.

Diff Detail

Repository
rP Phabricator
Branch
mailobj2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20410
Build 27717: Run Core Tests
Build 27716: arc lint + arc unit