Paths

Table of Contentst

Differential D19487

Add a generic PHID-based object redirection controller
ClosedPublic
Actions

Authored by epriestley on Jun 12 2018, 2:49 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13151: Plans: 2018 Week 23 - Week 30 Bonus Content

Commits

rP94752278f4cd: Add a generic PHID-based object redirection controller

Summary

Ref T13151. See PHI647. This allows us to link to any object by PHID, without disclosing information in the monogram (like #fire-steve).

This capability is relevant when building "secure mail", to provide a link to the object regardless of whether the monogram discloses information or not.

Test Plan

Visited /object/D123/ (redirect), /object/xyz/ (404), /object/PHID-DREV-.../ (redirect).

Diff Detail

Repository

rP Phabricator

Branch

mailobj1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20409
Build 27715: Run Core Tests
Build 27714: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 12 2018, 2:49 PM

Harbormaster completed remote builds in B20409: Diff 46603.Jun 12 2018, 2:51 PM

epriestley requested review of this revision.Jun 12 2018, 2:51 PM

epriestley added a child revision: D19488: Allow encrypted mail to be more specific about which object is affected.Jun 12 2018, 3:11 PM

amckinley accepted this revision.Jun 12 2018, 4:27 PM

This revision is now accepted and ready to land.Jun 12 2018, 4:27 PM

Closed by commit rP94752278f4cd: Add a generic PHID-based object redirection controller (authored by epriestley). · Explain WhyJun 12 2018, 6:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

system/

application/

PhabricatorSystemApplication.php

1 line

controller/

PhabricatorSystemObjectController.php

39 lines

Diff 46603

View Options

src/__phutil_library_map__.php

View Options

src/applications/system/application/PhabricatorSystemApplication.php

View Options

src/applications/system/controller/PhabricatorSystemObjectController.php

Add a generic PHID-based object redirection controllerClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 46603

src/__phutil_library_map__.php

src/applications/system/application/PhabricatorSystemApplication.php

src/applications/system/controller/PhabricatorSystemObjectController.php

Add a generic PHID-based object redirection controller
ClosedPublic
Actions

Revision Contents
Changeset List