Page MenuHomePhabricator

[ARCUNIT] Set the ConfigurationManager of ConfigurationDrivenUnitTestEngines
ClosedPublic

Authored by tmcjilton on Jun 5 2018, 8:30 PM.

Details

Summary

The Configuration Manager is supported by ArcanistUnitTestEngine but not support by the ArcanistConfigurationDrivenUnitTestEngine.

Added the configuration manager as one of the initially set properties of an ArcUnitTestEngine created by the ArcanistConfigurationDrivenTestEngine

Test Plan

Ran arc unit against a project without the change, verified the Configuration was none. Added this change and ran again and verified it was set

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 20368
Build 27660: arc lint + arc unit

Event Timeline

tmcjilton created this revision.Jun 5 2018, 8:30 PM
tmcjilton requested review of this revision.Jun 5 2018, 8:30 PM
epriestley accepted this revision.Jun 5 2018, 8:46 PM

Thanks! I added a CLA exemption for you and added you to Community (granting you sweeping janitorial powers) and Blessed Committers (so you should be able to land this yourself). See that project's detail page for instructions, and yell if you run into issues.

This revision is now accepted and ready to land.Jun 5 2018, 8:46 PM

(For future archaeology, see also PHI694.)

This revision was automatically updated to reflect the committed changes.