Page MenuHomePhabricator

When showing a diff-of-diffs, hide files which didn't get any more changes and have no inlines
ClosedPublic

Authored by epriestley on May 16 2018, 4:10 PM.
Tags
None
Referenced Files
F15443851: D19453.id46530.diff
Thu, Mar 27, 6:31 AM
F15442731: D19453.id46530.diff
Thu, Mar 27, 12:10 AM
F15441325: D19453.id.diff
Wed, Mar 26, 5:35 PM
F15438174: D19453.diff
Tue, Mar 25, 11:40 PM
F15436294: D19453.diff
Tue, Mar 25, 1:13 PM
F15421151: D19453.id.diff
Fri, Mar 21, 9:19 PM
F15413959: D19453.id46531.diff
Wed, Mar 19, 10:11 PM
F15291273: D19453.id46531.diff
Wed, Mar 5, 12:26 AM
Subscribers
None

Details

Summary

Ref T13137. See that task for discussion.

When we show a diff-of-diffs, we often render stubs for files which didn't change between the diffs. These stubs usually aren't a big deal, but for certain types of changes (like refactors) they can create a lot of clutter.

Instead, hide these stubs and show a notice that we hid them.

Test Plan
  • Created a revision affecting 4 files.
  • Updated it with a diff that changed only 1 of the 4 files.
  • Added an inline comment to a different file.
  • Viewed the diff of diffs.
    • Before: 4 changesets with two "nothing changed" stubs.
    • After: 2 changesets with the stubs hidden.

Screen Shot 2018-05-16 at 9.08.33 AM.png (538×1 px, 98 KB)

Diff Detail

Repository
rP Phabricator
Branch
changeset2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20338
Build 27621: Run Core Tests
Build 27620: arc lint + arc unit

Event Timeline

Since this relies on a content hash, it will only work when diffing diffs created after this goes live, unless you go retroactively rebuild a bunch of changesets with bin/differential rebuild-changesets.

  • If we would hide only one changeset, don't hide it. It's sort of pointless to hide one changeset and replace it with a notice that we hid it.

...it will only work when diffing diffs created after this goes live...

Which presumably is fine since users aren't generally viewing diff-of-diffs for already accepted revisions.

This revision is now accepted and ready to land.May 16 2018, 5:33 PM