When showing a diff-of-diffs, hide files which didn't get any more changes and have no inlines
ClosedPublic
Actions

Authored by epriestley on May 16 2018, 4:10 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13137: Plans: 2018 Week 19 - Week 22 Bonus Content

Commits

rP8f9b9484471a: When showing a diff-of-diffs, hide files which didn't get any more changes and…

Summary

Ref T13137. See that task for discussion.

When we show a diff-of-diffs, we often render stubs for files which didn't change between the diffs. These stubs usually aren't a big deal, but for certain types of changes (like refactors) they can create a lot of clutter.

Instead, hide these stubs and show a notice that we hid them.

Test Plan

Created a revision affecting 4 files.
Updated it with a diff that changed only 1 of the 4 files.
Added an inline comment to a different file.
Viewed the diff of diffs.
- Before: 4 changesets with two "nothing changed" stubs.
- After: 2 changesets with the stubs hidden.

Screen Shot 2018-05-16 at 9.08.33 AM.png (538×1 px, 98 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 16 2018, 4:10 PM

Since this relies on a content hash, it will only work when diffing diffs created after this goes live, unless you go retroactively rebuild a bunch of changesets with bin/differential rebuild-changesets.

Harbormaster completed remote builds in B20338: Diff 46530.May 16 2018, 4:11 PM

epriestley requested review of this revision.May 16 2018, 4:11 PM