Page MenuHomePhabricator

Fix a fatal during breadcrumb construction when viewing a dashboard you don't have permission to view
ClosedPublic

Authored by epriestley on May 14 2018, 3:48 PM.
Tags
None
Referenced Files
F17317931: D19449.diff
Thu, Jun 26, 5:22 PM
Unknown Object (File)
May 20 2025, 1:23 AM
Unknown Object (File)
May 19 2025, 8:00 PM
Unknown Object (File)
May 18 2025, 6:21 AM
Unknown Object (File)
Apr 27 2025, 1:26 AM
Unknown Object (File)
Apr 23 2025, 2:16 AM
Unknown Object (File)
Apr 18 2025, 12:56 PM
Unknown Object (File)
Apr 17 2025, 4:53 AM
Subscribers
None

Details

Summary

Ref PHI662. Viewing a dashboard you don't have permission to view (in the Dashboard application) currently fatals while building crumbs, since we fail to build the ... > Dashboard 123 > ... crumb.

Test Plan
  • Viewed a dashboard I didn't have permission to view in the Dashboards application.
  • Before patch, fatal when calling getID() on a non-object.
  • After patch, sensible policy error page.
  • Viewed a dashboard I can view, saw sensible crumbs.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable