Page MenuHomePhabricator

Fix a fatal during breadcrumb construction when viewing a dashboard you don't have permission to view
ClosedPublic

Authored by epriestley on May 14 2018, 3:48 PM.
Tags
None
Referenced Files
F18556536: D19449.diff
Mon, Sep 8, 6:59 PM
F18509636: D19449.id.diff
Fri, Sep 5, 3:31 AM
F18502893: D19449.diff
Thu, Sep 4, 10:43 PM
F18052259: D19449.id46524.diff
Aug 4 2025, 1:58 AM
F18050890: D19449.id46518.diff
Aug 3 2025, 9:25 PM
F18043802: D19449.diff
Aug 3 2025, 6:24 AM
Unknown Object (File)
Jun 27 2025, 2:23 AM
Unknown Object (File)
Jun 26 2025, 5:22 PM
Subscribers
None

Details

Summary

Ref PHI662. Viewing a dashboard you don't have permission to view (in the Dashboard application) currently fatals while building crumbs, since we fail to build the ... > Dashboard 123 > ... crumb.

Test Plan
  • Viewed a dashboard I didn't have permission to view in the Dashboards application.
  • Before patch, fatal when calling getID() on a non-object.
  • After patch, sensible policy error page.
  • Viewed a dashboard I can view, saw sensible crumbs.

Diff Detail

Repository
rP Phabricator
Branch
dashpol1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20324
Build 27600: Run Core Tests
Build 27599: arc lint + arc unit