Page MenuHomePhabricator

Fix a fatal during breadcrumb construction when viewing a dashboard you don't have permission to view
ClosedPublic

Authored by epriestley on May 14 2018, 3:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 6:05 AM
Unknown Object (File)
Tue, Feb 4, 5:35 AM
Unknown Object (File)
Sun, Feb 2, 9:53 AM
Unknown Object (File)
Tue, Jan 28, 4:12 PM
Unknown Object (File)
Sat, Jan 25, 1:30 AM
Unknown Object (File)
Tue, Jan 21, 9:21 AM
Unknown Object (File)
Sat, Jan 18, 7:27 AM
Unknown Object (File)
Dec 27 2024, 6:53 PM
Subscribers
None

Details

Summary

Ref PHI662. Viewing a dashboard you don't have permission to view (in the Dashboard application) currently fatals while building crumbs, since we fail to build the ... > Dashboard 123 > ... crumb.

Test Plan
  • Viewed a dashboard I didn't have permission to view in the Dashboards application.
  • Before patch, fatal when calling getID() on a non-object.
  • After patch, sensible policy error page.
  • Viewed a dashboard I can view, saw sensible crumbs.

Diff Detail

Repository
rP Phabricator
Branch
dashpol1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20324
Build 27600: Run Core Tests
Build 27599: arc lint + arc unit