Page MenuHomePhabricator

Raise the intraline diff hard limit from 80 to 100 characters
ClosedPublic

Authored by epriestley on May 9 2018, 8:33 PM.
Tags
None
Referenced Files
F15572722: D19442.id.diff
Mon, May 5, 5:21 PM
F15553268: D19442.id46504.diff
Mon, Apr 28, 1:02 AM
F15549072: D19442.id46503.diff
Sun, Apr 27, 3:40 AM
F15538466: D19442.id46503.diff
Thu, Apr 24, 7:29 PM
F15538202: D19442.id46503.diff
Thu, Apr 24, 6:03 PM
F15534471: D19442.diff
Thu, Apr 24, 12:26 AM
F15438555: D19442.id46504.diff
Mar 26 2025, 1:29 AM
F15437334: D19442.id46503.diff
Mar 25 2025, 6:54 PM
Subscribers
None

Details

Summary

Fixes T1246. See PHI637. See T13137. Computers have gotten a bit faster so we can probably bump this up a little and see if it causes problems. This is O(N^2) so the this should be less than twice as expensive in the worst case.

Test Plan

Created a diff affecting characters on a very long line separated by more than 80 but fewer than 100 characters, got a good intraline diff out of it:

Screen Shot 2018-05-09 at 1.30.52 PM.png (1×2 px, 243 KB)

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable