Page MenuHomePhabricator

Mention the "inline comments" rule in the callout for "Large" diffs
ClosedPublic

Authored by epriestley on May 6 2018, 1:32 PM.
Tags
None
Referenced Files
F18993317: D19430.diff
Wed, Nov 19, 7:45 AM
F18868942: D19430.id.diff
Nov 4 2025, 9:20 AM
F18866921: D19430.diff
Nov 3 2025, 8:17 PM
F18864911: D19430.id46477.diff
Nov 3 2025, 9:16 AM
F18862639: D19430.id46476.diff
Nov 2 2025, 8:05 PM
F18815277: D19430.diff
Oct 21 2025, 1:33 AM
F18778888: D19430.id46477.diff
Oct 11 2025, 11:13 AM
F18745861: D19430.id.diff
Oct 3 2025, 10:02 AM
Subscribers
None

Details

Summary

See PHI638. When a diff is large (between 100 and 1000 files), we collapse content by default unless a change also has inline comments.

This rule isn't explicitly explained anywhere. Although it's not really a critical rule, it fits easily enough into the UI callout.

Also render the UI callout in a slightly more modern way and avoid hsprintf().

Test Plan

Screen Shot 2018-05-06 at 6.30.16 AM.png (1×1 px, 216 KB)

  • Also, clicked the "Expand" link and saw everything expand properly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable