Page MenuHomePhabricator

Mention the "inline comments" rule in the callout for "Large" diffs
ClosedPublic

Authored by epriestley on May 6 2018, 1:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 21, 6:38 PM
Unknown Object (File)
Tue, Apr 16, 12:33 AM
Unknown Object (File)
Tue, Apr 2, 1:19 AM
Unknown Object (File)
Fri, Mar 29, 1:32 AM
Unknown Object (File)
Wed, Mar 27, 7:56 AM
Unknown Object (File)
Wed, Mar 27, 7:56 AM
Unknown Object (File)
Wed, Mar 27, 7:56 AM
Unknown Object (File)
Wed, Mar 27, 7:56 AM
Subscribers
None

Details

Summary

See PHI638. When a diff is large (between 100 and 1000 files), we collapse content by default unless a change also has inline comments.

This rule isn't explicitly explained anywhere. Although it's not really a critical rule, it fits easily enough into the UI callout.

Also render the UI callout in a slightly more modern way and avoid hsprintf().

Test Plan

Screen Shot 2018-05-06 at 6.30.16 AM.png (1×1 px, 216 KB)

  • Also, clicked the "Expand" link and saw everything expand properly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable