Differential D19419

Pass full Harbormaster URIs to Buildkite
ClosedPublic
Actions

Authored by epriestley on Apr 30 2018, 11:01 PM.

Tags

None

Referenced Files

	F18940882: D19419.diff
	Tue, Nov 11, 9:13 AM

	F18809107: D19419.id.diff
	Oct 19 2025, 11:12 AM

	F18798539: D19419.id46453.diff
	Oct 17 2025, 6:44 AM

	F18790618: D19419.id46454.diff
	Oct 15 2025, 4:04 PM

	F18714985: D19419.diff
	Sep 29 2025, 9:04 AM

	F18657831: D19419.diff
	Sep 23 2025, 3:37 AM

	F18509608: D19419.id.diff
	Sep 5 2025, 3:30 AM

	F18502828: D19419.diff
	Sep 4 2025, 10:40 PM

View All Files

Subscribers

Restricted Owners Package

Details

Reviewers

amckinley

Commits

rP7cfac40a225b: Pass full Harbormaster URIs to Buildkite

Summary

See PHI611 for details.

Test Plan

Ran a Buildkite build, saw Buildkite confirm receipt of these parameters in the HTTP response:

Diff Detail

Repository

rP Phabricator

Branch

kite1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20265
Build 27507: Run Core Tests
Build 27506: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 30 2018, 11:01 PM

Owners added a subscriber: Restricted Owners Package.Apr 30 2018, 11:01 PM

Harbormaster completed remote builds in B20264: Diff 46453.Apr 30 2018, 11:02 PM

epriestley requested review of this revision.Apr 30 2018, 11:02 PM

More/different magic.

Harbormaster completed remote builds in B20265: Diff 46454.May 1 2018, 12:09 AM

amckinley accepted this revision.May 1 2018, 1:01 AM

This revision is now accepted and ready to land.May 1 2018, 1:01 AM

Closed by commit rP7cfac40a225b: Pass full Harbormaster URIs to Buildkite (authored by epriestley). · Explain WhyMay 1 2018, 5:32 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

step/

HarbormasterBuildkiteBuildStepImplementation.php

8 lines

Diff 46454

View Options

src/applications/harbormaster/step/HarbormasterBuildkiteBuildStepImplementation.php

Pass full Harbormaster URIs to BuildkiteClosedPublicActions