Differential D19419

Pass full Harbormaster URIs to Buildkite
ClosedPublic
Actions

Authored by epriestley on Apr 30 2018, 11:01 PM.

Tags

None

Referenced Files

	F15549612: D19419.id46455.diff
	Sun, Apr 27, 6:53 AM

	F15538561: D19419.diff
	Thu, Apr 24, 8:00 PM

	F15528991: D19419.id46453.diff
	Tue, Apr 22, 3:53 PM

	F15523636: D19419.diff
	Mon, Apr 21, 2:40 AM

	F15517738: D19419.id.diff
	Sat, Apr 19, 8:08 AM

	F15515234: D19419.diff
	Fri, Apr 18, 8:53 AM

	F15424493: D19419.id46455.diff
	Mar 22 2025, 10:41 PM

	F15409220: D19419.diff
	Mar 19 2025, 3:39 AM

View All Files

Subscribers

Restricted Owners Package

Details

Reviewers

amckinley

Commits

rP7cfac40a225b: Pass full Harbormaster URIs to Buildkite

Summary

See PHI611 for details.

Test Plan

Ran a Buildkite build, saw Buildkite confirm receipt of these parameters in the HTTP response:

Diff Detail

Repository

rP Phabricator

Branch

kite1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20264
Build 27505: Run Core Tests
Build 27504: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 30 2018, 11:01 PM

Owners added a subscriber: Restricted Owners Package.Apr 30 2018, 11:01 PM

Harbormaster completed remote builds in B20264: Diff 46453.Apr 30 2018, 11:02 PM

epriestley requested review of this revision.Apr 30 2018, 11:02 PM

More/different magic.

Harbormaster completed remote builds in B20265: Diff 46454.May 1 2018, 12:09 AM

amckinley accepted this revision.May 1 2018, 1:01 AM

This revision is now accepted and ready to land.May 1 2018, 1:01 AM

Closed by commit rP7cfac40a225b: Pass full Harbormaster URIs to Buildkite (authored by epriestley). · Explain WhyMay 1 2018, 5:32 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

step/

HarbormasterBuildkiteBuildStepImplementation.php

6 lines

Diff 46453

View Options

src/applications/harbormaster/step/HarbormasterBuildkiteBuildStepImplementation.php

Pass full Harbormaster URIs to BuildkiteClosedPublicActions