Page MenuHomePhabricator

Fix an issue where the Herald test console doesn't work with "Content source" rules
ClosedPublic

Authored by epriestley on Apr 27 2018, 6:16 PM.
Tags
None
Referenced Files
F18219864: D19411.id46425.diff
Tue, Aug 19, 12:45 PM
F18216806: D19411.id46432.diff
Tue, Aug 19, 7:59 AM
F18203544: D19411.id.diff
Mon, Aug 18, 12:27 PM
F18193736: D19411.diff
Sun, Aug 17, 6:37 AM
F17754820: D19411.diff
Jul 22 2025, 11:25 AM
Unknown Object (File)
Jun 30 2025, 2:27 PM
Unknown Object (File)
Jun 27 2025, 11:26 AM
Unknown Object (File)
Jun 27 2025, 12:39 AM
Subscribers
None

Details

Summary

Ref T13130. See PHI619. Currently, the Herald "Test Console" doesn't pass a "Content Source" to the adapter, so if any rules of the given type execute a "Content source" field rule, they'll fatal.

Provide a content source:

  • If possible, use the content source from the most recent transaction.
  • Otherwise, build a default "web" content source from the current request.
Test Plan
  • Wrote a "When [content source][is][whatever]" rule for tasks.
  • Ran test console against a task.
  • Before: got a fatal trying to interact with the content source.
  • After: transcript reports sensible content source.
    • Also commented out the "xaction" logic to test the fallback behavior.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable