Page MenuHomePhabricator

Fix an issue where the Herald test console doesn't work with "Content source" rules
ClosedPublic

Authored by epriestley on Apr 27 2018, 6:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 29, 4:57 PM
Unknown Object (File)
Tue, Jan 28, 3:49 AM
Unknown Object (File)
Sat, Jan 25, 1:20 AM
Unknown Object (File)
Sat, Jan 25, 1:20 AM
Unknown Object (File)
Sat, Jan 25, 1:19 AM
Unknown Object (File)
Tue, Jan 21, 10:07 AM
Unknown Object (File)
Fri, Jan 17, 10:53 AM
Unknown Object (File)
Tue, Jan 14, 10:46 PM
Subscribers
None

Details

Summary

Ref T13130. See PHI619. Currently, the Herald "Test Console" doesn't pass a "Content Source" to the adapter, so if any rules of the given type execute a "Content source" field rule, they'll fatal.

Provide a content source:

  • If possible, use the content source from the most recent transaction.
  • Otherwise, build a default "web" content source from the current request.
Test Plan
  • Wrote a "When [content source][is][whatever]" rule for tasks.
  • Ran test console against a task.
  • Before: got a fatal trying to interact with the content source.
  • After: transcript reports sensible content source.
    • Also commented out the "xaction" logic to test the fallback behavior.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable