Page MenuHomePhabricator

Fix an issue where the Herald test console doesn't work with "Content source" rules
ClosedPublic

Authored by epriestley on Apr 27 2018, 6:16 PM.
Tags
None
Referenced Files
F15555640: D19411.id46425.diff
Mon, Apr 28, 12:28 PM
F15548232: D19411.id46432.diff
Sat, Apr 26, 10:37 PM
F15541630: D19411.id.diff
Fri, Apr 25, 12:37 PM
F15539294: D19411.id46432.diff
Fri, Apr 25, 12:35 AM
F15535704: D19411.diff
Thu, Apr 24, 6:22 AM
F15521048: D19411.id46425.diff
Sun, Apr 20, 10:37 AM
F15490863: D19411.id46425.diff
Fri, Apr 11, 9:11 PM
F15489627: D19411.id46432.diff
Fri, Apr 11, 10:56 AM
Subscribers
None

Details

Summary

Ref T13130. See PHI619. Currently, the Herald "Test Console" doesn't pass a "Content Source" to the adapter, so if any rules of the given type execute a "Content source" field rule, they'll fatal.

Provide a content source:

  • If possible, use the content source from the most recent transaction.
  • Otherwise, build a default "web" content source from the current request.
Test Plan
  • Wrote a "When [content source][is][whatever]" rule for tasks.
  • Ran test console against a task.
  • Before: got a fatal trying to interact with the content source.
  • After: transcript reports sensible content source.
    • Also commented out the "xaction" logic to test the fallback behavior.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable