Paths

Table of Contentst

Differential D19410

Fix an issue in the new Harbormaster build log view where clicking the "^" icon doesn't work right
ClosedPublic
Actions

Authored by epriestley on Apr 27 2018, 6:00 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13130: Plans: 2018 Week 17/18 Bonus Content

Commits

rP28517110c6cb: Fix an issue in the new Harbormaster build log view where clicking the "^" icon…

Summary

Ref T13130. See PHI617.

The new build log UI has tags like <a href="...">Show More Above <span icon>^</span></a>. If you click the little "^" icon, the event target is the <span /> instead of the <a /> so we expand on the wrong node.

Instead, select the <a /> by sigil explicitly.

Test Plan

Viewed new log UI in Harbormaster, clicked "^" icon and text, got the same (correct) behavior on both.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 27 2018, 6:00 PM

Harbormaster completed remote builds in B20232: Diff 46423.Apr 27 2018, 6:01 PM

epriestley requested review of this revision.Apr 27 2018, 6:01 PM

amckinley accepted this revision.Apr 27 2018, 6:05 PM

This revision is now accepted and ready to land.Apr 27 2018, 6:05 PM

Closed by commit rP28517110c6cb: Fix an issue in the new Harbormaster build log view where clicking the "^" icon… (authored by epriestley). · Explain WhyApr 27 2018, 6:52 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

10 lines

webroot/

rsrc/

js/

application/

harbormaster/

behavior-harbormaster-log.js

2 lines

Diff 46427

View Options

resources/celerity/map.php