Page MenuHomePhabricator
Differential D19410

Fix an issue in the new Harbormaster build log view where clicking the "^" icon doesn't work right
ClosedPublic
Actions

Authored by epriestley on Apr 27 2018, 6:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 10, 10:52 AM
Unknown Object (File)
Fri, Dec 6, 8:18 PM
Unknown Object (File)
Mon, Dec 2, 8:03 PM
Unknown Object (File)
Mon, Dec 2, 8:03 PM
Unknown Object (File)
Mon, Dec 2, 8:02 PM
Unknown Object (File)
Mon, Dec 2, 8:02 PM
Unknown Object (File)
Sun, Dec 1, 7:25 AM
Unknown Object (File)
Thu, Nov 28, 1:28 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13130: Plans: 2018 Week 17/18 Bonus Content
Commits
rP28517110c6cb: Fix an issue in the new Harbormaster build log view where clicking the "^" icon…
Summary

Ref T13130. See PHI617.

The new build log UI has tags like <a href="...">Show More Above <span icon>^</span></a>. If you click the little "^" icon, the event target is the <span /> instead of the <a /> so we expand on the wrong node.

Instead, select the <a /> by sigil explicitly.

Test Plan

Viewed new log UI in Harbormaster, clicked "^" icon and text, got the same (correct) behavior on both.

Diff Detail

Repository
rP Phabricator
Branch
chevron1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20232
Build 27460: Run Core Tests
Build 27459: arc lint + arc unit

Revision Contents
Changeset List

PathSize
resources/
celerity/
10 lines
webroot/
rsrc/
js/
application/
harbormaster/
2 lines

Diff 46423

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/application/harbormaster/behavior-harbormaster-log.js

Loading...
Phabricator · Built by Phacility