Page MenuHomePhabricator

Fix an issue in the new Harbormaster build log view where clicking the "^" icon doesn't work right
ClosedPublic

Authored by epriestley on Apr 27 2018, 6:00 PM.
Tags
None
Referenced Files
F15397994: D19410.diff
Sun, Mar 16, 11:08 PM
F15334504: D19410.diff
Sat, Mar 8, 10:02 AM
Unknown Object (File)
Fri, Feb 21, 3:59 PM
Unknown Object (File)
Thu, Feb 20, 9:51 PM
Unknown Object (File)
Thu, Feb 20, 9:51 PM
Unknown Object (File)
Thu, Feb 20, 9:51 PM
Unknown Object (File)
Thu, Feb 20, 9:51 PM
Unknown Object (File)
Feb 10 2025, 11:50 AM
Subscribers
None

Details

Summary

Ref T13130. See PHI617.

The new build log UI has tags like <a href="...">Show More Above <span icon>^</span></a>. If you click the little "^" icon, the event target is the <span /> instead of the <a /> so we expand on the wrong node.

Instead, select the <a /> by sigil explicitly.

Test Plan

Viewed new log UI in Harbormaster, clicked "^" icon and text, got the same (correct) behavior on both.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable