Page MenuHomePhabricator

Fix an issue in the new Harbormaster build log view where clicking the "^" icon doesn't work right
ClosedPublic

Authored by epriestley on Apr 27 2018, 6:00 PM.
Tags
None
Referenced Files
F17932261: D19410.id.diff
Wed, Jul 30, 7:56 PM
F17918726: D19410.diff
Wed, Jul 30, 1:33 AM
F17867013: D19410.diff
Mon, Jul 28, 5:16 AM
Unknown Object (File)
Jun 5 2025, 1:55 AM
Unknown Object (File)
May 28 2025, 6:33 PM
Unknown Object (File)
May 28 2025, 1:24 AM
Unknown Object (File)
May 3 2025, 10:12 AM
Unknown Object (File)
Apr 25 2025, 6:13 PM
Subscribers
None

Details

Summary

Ref T13130. See PHI617.

The new build log UI has tags like <a href="...">Show More Above <span icon>^</span></a>. If you click the little "^" icon, the event target is the <span /> instead of the <a /> so we expand on the wrong node.

Instead, select the <a /> by sigil explicitly.

Test Plan

Viewed new log UI in Harbormaster, clicked "^" icon and text, got the same (correct) behavior on both.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable