Page MenuHomePhabricator

Support Herald rules for Herald rules
ClosedPublic

Authored by epriestley on Apr 23 2018, 9:07 PM.
Tags
None
Referenced Files
F17711945: D19400.diff
Thu, Jul 17, 9:20 AM
Unknown Object (File)
Tue, Jul 1, 6:14 AM
Unknown Object (File)
Mon, Jun 30, 8:42 AM
Unknown Object (File)
Sun, Jun 29, 5:28 PM
Unknown Object (File)
Sat, Jun 28, 12:42 PM
Unknown Object (File)
Fri, Jun 27, 11:30 AM
Unknown Object (File)
Fri, Jun 27, 3:38 AM
Unknown Object (File)
Fri, Jun 27, 12:43 AM
Subscribers
None

Details

Summary

Depends on D19399. Ref T13130. This adds basic support for writing Herald rules against Herald rules. See T13130 for a lot more detail.

This needs a bit more work to be useful: for example, there's no way to specify the rule type or subject, so you can't say "notify me when global rules are edited" or "notify me when Maniphest rules are edited". I'll add some fields for that in followup changes to actually solve the original use case.

Test Plan
  • Wrote Herald rules against Herald rules.
  • Ran them by editing rules and in the test console.
  • Verified they sent some mail with bin/mail list-outbound.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Looks good except for cruft.

src/applications/herald/adapter/HeraldRuleAdapter.php
26

"a another"

src/applications/herald/controller/HeraldRuleController.php
378 ↗(On Diff #46404)

Leftover logging.

This revision is now accepted and ready to land.Apr 23 2018, 9:45 PM
  • Fix "a another".
  • Remove stray "phlog()".
This revision was automatically updated to reflect the committed changes.