Page MenuHomePhabricator

Support Herald rules for Herald rules
ClosedPublic

Authored by epriestley on Apr 23 2018, 9:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 1:06 AM
Unknown Object (File)
Thu, Apr 11, 8:47 AM
Unknown Object (File)
Sun, Apr 7, 9:43 AM
Unknown Object (File)
Fri, Apr 5, 10:37 AM
Unknown Object (File)
Wed, Apr 3, 10:02 AM
Unknown Object (File)
Mar 27 2024, 7:43 AM
Unknown Object (File)
Mar 27 2024, 7:43 AM
Unknown Object (File)
Mar 27 2024, 7:43 AM
Subscribers
None

Details

Summary

Depends on D19399. Ref T13130. This adds basic support for writing Herald rules against Herald rules. See T13130 for a lot more detail.

This needs a bit more work to be useful: for example, there's no way to specify the rule type or subject, so you can't say "notify me when global rules are edited" or "notify me when Maniphest rules are edited". I'll add some fields for that in followup changes to actually solve the original use case.

Test Plan
  • Wrote Herald rules against Herald rules.
  • Ran them by editing rules and in the test console.
  • Verified they sent some mail with bin/mail list-outbound.

Diff Detail

Repository
rP Phabricator
Branch
herald1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20215
Build 27433: Run Core Tests
Build 27432: arc lint + arc unit

Event Timeline

Looks good except for cruft.

src/applications/herald/adapter/HeraldRuleAdapter.php
25

"a another"

src/applications/herald/controller/HeraldRuleController.php
378

Leftover logging.

This revision is now accepted and ready to land.Apr 23 2018, 9:45 PM
  • Fix "a another".
  • Remove stray "phlog()".
This revision was automatically updated to reflect the committed changes.