Differential D19392

Stop "git blame" from printing "^" markers on root repository commits
ClosedPublic
Actions

Authored by epriestley on Apr 20 2018, 8:11 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13126: Plans: Diffusion cleanup for document engine

Commits

rP8c78cde32f5e: Stop "git blame" from printing "^" markers on root repository commits

Summary

Depends on D19391. Ref T13126. See that task for some details on what's going on here.

Test Plan

Viewed a file which includes lines that were added during the first commit to the repository.
Before D19391: fatal.
After D19391: blank.
After this patch: accurate blame information.

Diff Detail

Repository

rP Phabricator

Branch

initial2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20199
Build 27411: Run Core Tests
Build 27410: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 20 2018, 8:11 PM

Harbormaster completed remote builds in B20199: Diff 46386.Apr 20 2018, 8:12 PM

epriestley requested review of this revision.Apr 20 2018, 8:12 PM

amckinley accepted this revision.Apr 20 2018, 9:05 PM

This revision is now accepted and ready to land.Apr 20 2018, 9:05 PM

Closed by commit rP8c78cde32f5e: Stop "git blame" from printing "^" markers on root repository commits (authored by epriestley). · Explain WhyApr 20 2018, 9:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

query/

blame/

DiffusionGitBlameQuery.php

6 lines

Diff 46386

View Options

src/applications/diffusion/query/blame/DiffusionGitBlameQuery.php

Stop "git blame" from printing "^" markers on root repository commitsClosedPublicActions