Page MenuHomePhabricator

Fix the most significant "phantom notification" badness
ClosedPublic

Authored by epriestley on Apr 19 2018, 5:59 PM.
Tags
None
Referenced Files
F19021065: D19384.diff
Sun, Nov 23, 6:48 PM
F18815291: D19384.id.diff
Oct 21 2025, 1:37 AM
F18808557: D19384.diff
Oct 19 2025, 7:09 AM
F18770168: D19384.id46374.diff
Oct 8 2025, 11:09 AM
F18670129: D19384.diff
Sep 24 2025, 11:11 PM
F18625786: D19384.id.diff
Sep 15 2025, 11:33 PM
F18611636: D19384.diff
Sep 14 2025, 7:29 AM
F18568171: D19384.id46374.diff
Sep 9 2025, 11:27 PM
Subscribers
None

Details

Summary

Ref T13124. Ref T13131. Fixes T8953. See PHI512.

When you receieve a notification about an object and then someone hides that object from you (or deletes it), you get a phantom notification which is very difficult to clear.

For now, test that notifications are visible when you open the menu and clear any that are not.

This could be a little more elegant than it is, but the current behavior is very clearly broken. This unbreaks it, at least.

Test Plan
  • As Alice, configured task stuff to notify me (instead of sending email).
  • As Bailey, added Alice as a subscriber to a task, then commented on it.
  • As Alice, loaded home and saw a notification count. Didn't click it yet.
  • As Bailey, set the task to private.
  • As Alice, clicked the notification bell menu icon.
    • Before change: no unread notifications, bell menu is semi-stuck in a phantom state which you can't clear.
    • After change: bad notifications automatically cleared.

Screen Shot 2018-04-19 at 10.49.00 AM.png (265×423 px, 31 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable