Page MenuHomePhabricator

Fix the most significant "phantom notification" badness
ClosedPublic

Authored by epriestley on Apr 19 2018, 5:59 PM.
Tags
None
Referenced Files
F17691405: D19384.id.diff
Mon, Jul 14, 9:55 PM
F17658644: D19384.id46374.diff
Sat, Jul 12, 1:34 PM
Unknown Object (File)
Fri, Jul 4, 1:45 PM
Unknown Object (File)
Jun 17 2025, 10:46 AM
Unknown Object (File)
Jun 16 2025, 12:37 AM
Unknown Object (File)
May 9 2025, 9:36 PM
Unknown Object (File)
May 8 2025, 8:05 AM
Unknown Object (File)
Apr 30 2025, 10:52 AM
Subscribers
None

Details

Summary

Ref T13124. Ref T13131. Fixes T8953. See PHI512.

When you receieve a notification about an object and then someone hides that object from you (or deletes it), you get a phantom notification which is very difficult to clear.

For now, test that notifications are visible when you open the menu and clear any that are not.

This could be a little more elegant than it is, but the current behavior is very clearly broken. This unbreaks it, at least.

Test Plan
  • As Alice, configured task stuff to notify me (instead of sending email).
  • As Bailey, added Alice as a subscriber to a task, then commented on it.
  • As Alice, loaded home and saw a notification count. Didn't click it yet.
  • As Bailey, set the task to private.
  • As Alice, clicked the notification bell menu icon.
    • Before change: no unread notifications, bell menu is semi-stuck in a phantom state which you can't clear.
    • After change: bad notifications automatically cleared.

Screen Shot 2018-04-19 at 10.49.00 AM.png (265×423 px, 31 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable