Page MenuHomePhabricator

Fix the most significant "phantom notification" badness
ClosedPublic

Authored by epriestley on Apr 19 2018, 5:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 10:08 PM
Unknown Object (File)
Sun, Nov 10, 5:13 PM
Unknown Object (File)
Wed, Nov 6, 9:56 PM
Unknown Object (File)
Oct 14 2024, 2:34 PM
Unknown Object (File)
Oct 6 2024, 10:11 PM
Unknown Object (File)
Oct 1 2024, 7:27 PM
Unknown Object (File)
Sep 6 2024, 3:13 AM
Unknown Object (File)
Sep 4 2024, 10:32 PM
Subscribers
None

Details

Summary

Ref T13124. Ref T13131. Fixes T8953. See PHI512.

When you receieve a notification about an object and then someone hides that object from you (or deletes it), you get a phantom notification which is very difficult to clear.

For now, test that notifications are visible when you open the menu and clear any that are not.

This could be a little more elegant than it is, but the current behavior is very clearly broken. This unbreaks it, at least.

Test Plan
  • As Alice, configured task stuff to notify me (instead of sending email).
  • As Bailey, added Alice as a subscriber to a task, then commented on it.
  • As Alice, loaded home and saw a notification count. Didn't click it yet.
  • As Bailey, set the task to private.
  • As Alice, clicked the notification bell menu icon.
    • Before change: no unread notifications, bell menu is semi-stuck in a phantom state which you can't clear.
    • After change: bad notifications automatically cleared.

Screen Shot 2018-04-19 at 10.49.00 AM.png (265×423 px, 31 KB)

Diff Detail

Repository
rP Phabricator
Branch
notify1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20181
Build 27384: Run Core Tests
Build 27383: arc lint + arc unit