Page MenuHomePhabricator

Fix the most significant "phantom notification" badness
ClosedPublic

Authored by epriestley on Apr 19 2018, 5:59 PM.
Tags
None
Referenced Files
F12830813: D19384.diff
Thu, Mar 28, 12:24 PM
Unknown Object (File)
Mon, Mar 4, 8:59 PM
Unknown Object (File)
Feb 3 2024, 6:57 PM
Unknown Object (File)
Feb 3 2024, 6:49 PM
Unknown Object (File)
Dec 21 2023, 11:52 PM
Unknown Object (File)
Nov 30 2023, 12:25 AM
Unknown Object (File)
Nov 25 2023, 7:17 PM
Unknown Object (File)
Nov 15 2023, 7:08 AM
Subscribers
None

Details

Summary

Ref T13124. Ref T13131. Fixes T8953. See PHI512.

When you receieve a notification about an object and then someone hides that object from you (or deletes it), you get a phantom notification which is very difficult to clear.

For now, test that notifications are visible when you open the menu and clear any that are not.

This could be a little more elegant than it is, but the current behavior is very clearly broken. This unbreaks it, at least.

Test Plan
  • As Alice, configured task stuff to notify me (instead of sending email).
  • As Bailey, added Alice as a subscriber to a task, then commented on it.
  • As Alice, loaded home and saw a notification count. Didn't click it yet.
  • As Bailey, set the task to private.
  • As Alice, clicked the notification bell menu icon.
    • Before change: no unread notifications, bell menu is semi-stuck in a phantom state which you can't clear.
    • After change: bad notifications automatically cleared.

Screen Shot 2018-04-19 at 10.49.00 AM.png (265×423 px, 31 KB)

Diff Detail

Repository
rP Phabricator
Branch
notify1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20181
Build 27384: Run Core Tests
Build 27383: arc lint + arc unit