Paths

Table of Contentst

Differential D19378

Restore coverage reporting to Diffusion browse UI
ClosedPublic
Actions

Authored by epriestley on Apr 17 2018, 1:46 PM.

Tags

None

Referenced Files

	F14077187: D19378.diff
	Thu, Nov 21, 9:53 PM

	Unknown Object (File)
	Sun, Nov 17, 9:44 PM

	Unknown Object (File)
	Thu, Nov 14, 3:51 AM

	Unknown Object (File)
	Sun, Nov 10, 4:06 AM

	Unknown Object (File)
	Wed, Nov 6, 2:14 PM

	Unknown Object (File)
	Oct 9 2024, 9:25 AM

	Unknown Object (File)
	Oct 1 2024, 10:57 PM

	Unknown Object (File)
	Sep 24 2024, 3:48 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13105: Plans: Rich presentation and diff rendering pipelines for various file types
T13124: Plans: 2018 Week 16 Bonus Content
T13125: Plans: Code coverage reporting

Commits

rP665529ab60a1: Restore coverage reporting to Diffusion browse UI

Summary

Depends on D19377. Ref T13125. Ref T13124. Ref T13105. Coverage reporting in Diffusion didn't initially survive the transition to Document Engine; restore it.

This adds some tentative/theoretical support for multiple columns of coverage, but no way to actually produce them in the UI. For now, the labels, codes, and colors are hard coded.

Test Plan

Added coverage with diffusion.updatecoverage, saw coverage in the UI:

Screen Shot 2018-04-17 at 6.43.40 AM.png (1×1 px, 231 KB)

Hovered over coverage, got labels and highlighting.

Double-checked labels for "N" (Not Executable) and "U" (Uncovered). See PHI577.

Faked some multi-column coverage, but you can't currently get this yourself today:

Screen Shot 2018-04-17 at 6.16.40 AM.png (1×1 px, 242 KB)

Diff Detail

Repository

Branch

covui2

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/files/document/render/PhabricatorDocumentRenderingEngine.php:150	XHP16	TODO Comment
Advice	src/view/layout/PhabricatorSourceCodeView.php:115	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 20168
Build 27364: Run Core Tests
Build 27363: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 17 2018, 1:46 PM

Harbormaster completed remote builds in B20168: Diff 46353.Apr 17 2018, 1:47 PM

epriestley requested review of this revision.Apr 17 2018, 1:47 PM

amckinley accepted this revision.Apr 17 2018, 4:45 PM

This revision is now accepted and ready to land.Apr 17 2018, 4:45 PM

Closed by commit rP665529ab60a1: Restore coverage reporting to Diffusion browse UI (authored by epriestley). · Explain WhyApr 17 2018, 9:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

18 lines

src/

applications/

diffusion/

controller/

DiffusionBrowseController.php

2 lines

document/

DiffusionDocumentRenderingEngine.php

5 lines

files/

document/

PhabricatorDocumentRef.php

12 lines

PhabricatorSourceDocumentEngine.php

4 lines

PhabricatorTextDocumentEngine.php

6 lines

render/

PhabricatorDocumentRenderingEngine.php

11 lines

view/

layout/

PhabricatorSourceCodeView.php

45 lines

webroot/

rsrc/

css/

layout/

phabricator-source-code-view.css

12 lines

js/

application/

files/

behavior-document-engine.js

59 lines

Diff 46353

resources/celerity/map.php

Loading...

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...

src/applications/diffusion/document/DiffusionDocumentRenderingEngine.php

Loading...

src/applications/files/document/PhabricatorDocumentRef.php

Loading...

src/applications/files/document/PhabricatorSourceDocumentEngine.php

Loading...

src/applications/files/document/PhabricatorTextDocumentEngine.php

Loading...

src/applications/files/document/render/PhabricatorDocumentRenderingEngine.php

Loading...

src/view/layout/PhabricatorSourceCodeView.php

Loading...

webroot/rsrc/css/layout/phabricator-source-code-view.css

Loading...

webroot/rsrc/js/application/files/behavior-document-engine.js

Loading...