Page MenuHomePhabricator

Restore coverage reporting to Diffusion browse UI
ClosedPublic

Authored by epriestley on Apr 17 2018, 1:46 PM.

Details

Summary

Depends on D19377. Ref T13125. Ref T13124. Ref T13105. Coverage reporting in Diffusion didn't initially survive the transition to Document Engine; restore it.

This adds some tentative/theoretical support for multiple columns of coverage, but no way to actually produce them in the UI. For now, the labels, codes, and colors are hard coded.

Test Plan

Added coverage with diffusion.updatecoverage, saw coverage in the UI:

Hovered over coverage, got labels and highlighting.

Double-checked labels for "N" (Not Executable) and "U" (Uncovered). See PHI577.

Faked some multi-column coverage, but you can't currently get this yourself today:

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Apr 17 2018, 1:46 PM
epriestley requested review of this revision.Apr 17 2018, 1:47 PM
amckinley accepted this revision.Apr 17 2018, 4:45 PM
This revision is now accepted and ready to land.Apr 17 2018, 4:45 PM
This revision was automatically updated to reflect the committed changes.