Page MenuHomePhabricator

Initial CloudWatch metric reporting support
ClosedPublic

Authored by amckinley on Apr 12 2018, 11:25 PM.
Tags
None
Referenced Files
F19507773: D19363.diff
Fri, Jan 9, 11:08 PM
F19229873: D19363.diff
Sun, Dec 21, 6:35 AM
F19134741: D19363.diff
Dec 10 2025, 8:43 AM
F18875526: D19363.id.diff
Nov 5 2025, 6:14 PM
F18868081: D19363.diff
Nov 4 2025, 4:32 AM
F18851159: D19363.id46328.diff
Oct 30 2025, 10:37 PM
F18829617: D19363.diff
Oct 24 2025, 11:17 PM
F18818919: D19363.diff
Oct 22 2025, 3:14 AM
Subscribers

Details

Summary

Ref T12857. Ref T13076. Initial infrastrucutre for creating and submitting CloudWatch metrics to AWS.

Test Plan

Submitted some metrics, saw them show up.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

wrong concatenation operator

epriestley added inline comments.
src/future/aws/PhutilCloudWatchMetric.php
47

I think this construction means that adding the same dimension with different values will silently do nothing the second time, which is maybe a little weird:

$metric->addDimension('a', 1);
$metric->addDimension('a', 2); // Does nothing.

Consider:

$this->dimensions[$name] = $value;

...to make a second call override, or an array_key_exists() test plus throw ... to make a second call an error.

This revision is now accepted and ready to land.Apr 13 2018, 11:53 AM
This revision was automatically updated to reflect the committed changes.