Page MenuHomePhabricator

Respect external unmentionable PHIDs in Differential revision editor
ClosedPublic

Authored by epriestley on Apr 12 2018, 10:03 PM.
Tags
None
Referenced Files
F14412005: D19361.diff
Tue, Dec 24, 12:28 PM
Unknown Object (File)
Wed, Dec 18, 4:45 AM
Unknown Object (File)
Nov 18 2024, 6:03 AM
Unknown Object (File)
Oct 29 2024, 8:29 PM
Unknown Object (File)
Oct 26 2024, 2:44 PM
Unknown Object (File)
Sep 12 2024, 12:14 PM
Unknown Object (File)
Sep 12 2024, 9:31 AM
Unknown Object (File)
Sep 10 2024, 2:50 AM
Subscribers
None

Details

Summary

See PHI574. Ref T13120. When you Ref Txx or Fixes Txxx, we mark it "unmentionable" to prevent the task from generating both a reference and a mention.

If you add a reference to an object (like a commit hash) to a custom remarkup field, there's currently no real way to prevent it from generating a mention, except that you can explicitly mark the PHID as unmentionable on the Editor.

This isn't exactly a first-class feature, but we technically do it in PhabricatorRepositoryCommitMessageParserWorker, and it probably doesn't hurt or interfere with anything to support it slightly better.

In Differential, respect any existing value and append new values to it rather than overwriting the value.

Test Plan

Edited a revision summary to include Ref Txxx, saw only a reference (not a mention) generate.

Diff Detail

Repository
rP Phabricator
Branch
unmention1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20128
Build 27308: Run Core Tests
Build 27307: arc lint + arc unit