Page MenuHomePhabricator

Roughly modularize document rendering in Files
ClosedPublic

Authored by epriestley on Mar 19 2018, 4:42 PM.
Tags
None
Referenced Files
F13096718: D19237.diff
Thu, Apr 25, 6:32 PM
Unknown Object (File)
Fri, Apr 19, 7:33 PM
Unknown Object (File)
Sat, Apr 13, 5:01 AM
Unknown Object (File)
Mon, Apr 8, 12:23 PM
Unknown Object (File)
Tue, Apr 2, 8:44 AM
Unknown Object (File)
Tue, Apr 2, 6:09 AM
Unknown Object (File)
Sun, Mar 31, 11:23 AM
Unknown Object (File)
Sun, Mar 31, 2:35 AM
Subscribers
None
Tokens
"Like" token, awarded by mydeveloperday.

Details

Summary

Ref T13105. This change begins modularizing document rendering. I'm starting in Files since it's the use case with the smallest amount of complexity.

Currently, we hard-coding the inline rendering for images, audio, and video. Instead, use the modular engine pattern to make rendering flexible and extensible.

There aren't any options for switching modes yet and none of the renderers do anything fancy. This API is also probably very unstable.

Test Plan

Viewwed images, audio, video, and other files. Saw reasonable renderings, with "nothing can render this" for any other file type.

Diff Detail

Repository
rP Phabricator
Branch
doc1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19880
Build 26942: Run Core Tests
Build 26941: arc lint + arc unit