Page MenuHomePhabricator
Differential D19189

Remove very old "owners-default-path" code from Owners
ClosedPublic
Actions

Authored by epriestley on Mar 8 2018, 12:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 10:09 AM
Unknown Object (File)
Sat, Apr 6, 2:57 AM
Unknown Object (File)
Wed, Apr 3, 2:33 PM
Unknown Object (File)
Mon, Apr 1, 6:32 AM
Unknown Object (File)
Sun, Mar 31, 5:11 AM
Unknown Object (File)
Sun, Mar 31, 5:10 AM
Unknown Object (File)
Sun, Mar 31, 5:09 AM
Unknown Object (File)
Sun, Mar 31, 2:23 AM
View All 91 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T12590: Owners expects users to choose a repository with a <select /> that lists every repository in ID order
Commits
rPab0ac7f61bab: Remove very old "owners-default-path" code from Owners
Summary

Ref T12590. This is ancient code which was used to prefill /trunk/tfb/www/ or similar at Facebook. I don't think it ever had a UI and no install has asked for this feature since 2011.

Test Plan

Grepped for affected symbols, edited paths in Owners.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 8 2018, 12:44 AM
Harbormaster completed remote builds in B19777: Diff 45960.Mar 8 2018, 12:45 AM
epriestley requested review of this revision.Mar 8 2018, 12:45 AM
epriestley added a child revision: D19190: Fix broken suggestion/validation for Owners paths in repositories with short names.Mar 8 2018, 1:33 AM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 8 2018, 2:25 AM
Closed by commit rPab0ac7f61bab: Remove very old "owners-default-path" code from Owners (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
40 lines
src/
applications/
owners/
controller/
11 lines
webroot/
rsrc/
js/
application/
herald/
7 lines
owners/
7 lines

Diff 45963

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/owners/controller/PhabricatorOwnersPathsController.php

Loading...
View Options

webroot/rsrc/js/application/herald/PathTypeahead.js

Loading...
View Options

webroot/rsrc/js/application/owners/OwnersPathEditor.js

Loading...
Phabricator · Built by Phacility