Page MenuHomePhabricator
Differential D19189

Remove very old "owners-default-path" code from Owners
ClosedPublic
Actions

Authored by epriestley on Mar 8 2018, 12:44 AM.
Tags
None
Referenced Files
F14848048: D19189.diff
Mon, Feb 3, 5:46 PM
Unknown Object (File)
Thu, Jan 30, 7:26 AM
Unknown Object (File)
Tue, Jan 28, 7:53 PM
Unknown Object (File)
Sun, Jan 26, 7:01 AM
Unknown Object (File)
Sat, Jan 25, 12:33 AM
Unknown Object (File)
Sat, Jan 25, 12:33 AM
Unknown Object (File)
Sat, Jan 25, 12:33 AM
Unknown Object (File)
Fri, Jan 24, 11:41 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T12590: Owners expects users to choose a repository with a <select /> that lists every repository in ID order
Commits
rPab0ac7f61bab: Remove very old "owners-default-path" code from Owners
Summary

Ref T12590. This is ancient code which was used to prefill /trunk/tfb/www/ or similar at Facebook. I don't think it ever had a UI and no install has asked for this feature since 2011.

Test Plan

Grepped for affected symbols, edited paths in Owners.

Diff Detail

Repository
rP Phabricator
Branch
owners1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19777
Build 26790: Run Core Tests
Build 26789: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 8 2018, 12:44 AM
Harbormaster completed remote builds in B19777: Diff 45960.Mar 8 2018, 12:45 AM
epriestley requested review of this revision.Mar 8 2018, 12:45 AM
epriestley added a child revision: D19190: Fix broken suggestion/validation for Owners paths in repositories with short names.Mar 8 2018, 1:33 AM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 8 2018, 2:25 AM
Closed by commit rPab0ac7f61bab: Remove very old "owners-default-path" code from Owners (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
40 lines
src/
applications/
owners/
controller/
11 lines
webroot/
rsrc/
js/
application/
herald/
7 lines
owners/
7 lines

Diff 45960

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/owners/controller/PhabricatorOwnersPathsController.php

Loading...
View Options

webroot/rsrc/js/application/herald/PathTypeahead.js

Loading...
View Options

webroot/rsrc/js/application/owners/OwnersPathEditor.js

Loading...
Phabricator · Built by Phacility