Page MenuHomePhabricator

Parameterize PhabricatorGlobalLock
ClosedPublic

Authored by epriestley on Mar 5 2018, 10:11 PM.
Tags
None
Referenced Files
F15457729: D19173.id45929.diff
Sun, Mar 30, 6:13 PM
F15445038: D19173.id.diff
Thu, Mar 27, 12:20 PM
F15439716: D19173.diff
Wed, Mar 26, 9:02 AM
F15423297: D19173.diff
Sat, Mar 22, 2:34 PM
F15389974: D19173.id.diff
Sat, Mar 15, 5:48 AM
F15337548: D19173.id45927.diff
Sun, Mar 9, 6:19 AM
F15336975: D19173.diff
Sun, Mar 9, 3:37 AM
Unknown Object (File)
Feb 27 2025, 7:28 PM
Subscribers
None

Details

Summary

Ref T13096. Currently, we do a fair amount of clever digesting and string manipulation to build lock names which are less than 64 characters long while still being reasonably readable.

Instead, do more of this automatically. This will let lock acquisition become simpler and make it more possible to build a useful lock log.

Test Plan

Ran bin/repository update, saw a reasonable lock acquire and release.

Diff Detail

Repository
rP Phabricator
Branch
lock1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19738
Build 26734: Run Core Tests
Build 26733: arc lint + arc unit