Page MenuHomePhabricator

Add a "lock log" for debugging where locks are being held
ClosedPublic

Authored by epriestley on Mar 5 2018, 11:27 PM.
Tags
None
Referenced Files
F15558754: D19174.id45930.diff
Tue, Apr 29, 5:18 AM
F15556950: D19174.id.diff
Mon, Apr 28, 7:10 PM
F15550159: D19174.diff
Sun, Apr 27, 9:47 AM
F15516803: D19174.id45928.diff
Fri, Apr 18, 9:29 PM
F15516802: D19174.id.diff
Fri, Apr 18, 9:29 PM
F15516540: D19174.id45930.diff
Fri, Apr 18, 7:34 PM
F15508547: D19174.id45928.diff
Wed, Apr 16, 6:04 AM
F15496982: D19174.id45930.diff
Sun, Apr 13, 9:12 AM
Subscribers
None

Details

Summary

Depends on D19173. Ref T13096. Adds an optional, disabled-by-default lock log to make it easier to figure out what is acquiring and holding locks.

Test Plan

Ran bin/lock log --enable, --disable, --name, etc. Saw sensible-looking output with log enabled and daemons restarted. Saw no additional output with log disabled and daemons restarted.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Draft.Mar 6 2018, 1:55 AM
This revision was automatically updated to reflect the committed changes.