Page MenuHomePhabricator
Differential D19174

Add a "lock log" for debugging where locks are being held
ClosedPublic
Actions

Authored by epriestley on Mar 5 2018, 11:27 PM.
Tags
None
Referenced Files
F18822841: D19174.diff
Thu, Oct 23, 8:50 AM
F18764069: D19174.id45928.diff
Tue, Oct 7, 4:04 AM
F18509390: D19174.id.diff
Sep 5 2025, 3:22 AM
F18502320: D19174.diff
Sep 4 2025, 10:21 PM
F18459585: D19174.diff
Sep 1 2025, 5:26 PM
F18217669: D19174.diff
Aug 19 2025, 9:10 AM
F18094947: D19174.id.diff
Aug 7 2025, 10:26 PM
F17949883: D19174.diff
Jul 31 2025, 11:59 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13096: Implement a global lock log to make it easier to debug global locks
Commits
rP44f0664d2c6f: Add a "lock log" for debugging where locks are being held
Summary

Depends on D19173. Ref T13096. Adds an optional, disabled-by-default lock log to make it easier to figure out what is acquiring and holding locks.

Test Plan

Ran bin/lock log --enable, --disable, --name, etc. Saw sensible-looking output with log enabled and daemons restarted. Saw no additional output with log disabled and daemons restarted.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 5 2018, 11:27 PM
Harbormaster failed remote builds in B19739: Diff 45928!Mar 5 2018, 11:27 PM
This revision was not accepted when it landed; it landed in state Draft.Mar 6 2018, 1:55 AM
Closed by commit rP44f0664d2c6f: Add a "lock log" for debugging where locks are being held (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
bin/
1 line
resources/
sql/
autopatches/
9 lines
scripts/
setup/
21 lines
src/
8 lines
applications/
daemon/
garbagecollector/
29 lines
management/
222 lines
4 lines
storage/
32 lines
infrastructure/
daemon/
garbagecollector/
6 lines
storage/
management/
workflow/
12 lines
util/
51 lines

Diff 45930

View Options

bin/lock

Loading...
View Options

resources/sql/autopatches/20180305.lock.01.locklog.sql

Loading...
View Options

scripts/setup/manage_lock.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/daemon/garbagecollector/PhabricatorDaemonLockLogGarbageCollector.php

Loading...
View Options

src/applications/daemon/management/PhabricatorLockLogManagementWorkflow.php

Loading...
View Options

src/applications/daemon/management/PhabricatorLockManagementWorkflow.php

Loading...
View Options

src/applications/daemon/storage/PhabricatorDaemonLockLog.php

Loading...
View Options

src/infrastructure/daemon/garbagecollector/PhabricatorGarbageCollector.php

Loading...
View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php

Loading...
View Options

src/infrastructure/util/PhabricatorGlobalLock.php

Loading...
Phabricator · Built by Phacility