Page MenuHomePhabricator

Add a "lock log" for debugging where locks are being held
ClosedPublic

Authored by epriestley on Mar 5 2018, 11:27 PM.
Tags
None
Referenced Files
F15466070: D19174.id45928.diff
Thu, Apr 3, 1:14 AM
F15452574: D19174.id45930.diff
Sat, Mar 29, 6:05 AM
F15451391: D19174.id.diff
Fri, Mar 28, 9:50 PM
F15444573: D19174.diff
Thu, Mar 27, 10:09 AM
F15417833: D19174.diff
Thu, Mar 20, 6:56 PM
F15416115: D19174.id45930.diff
Thu, Mar 20, 9:20 AM
F15348082: D19174.id45928.diff
Mon, Mar 10, 2:14 PM
Unknown Object (File)
Feb 9 2025, 5:36 AM
Subscribers
None

Details

Summary

Depends on D19173. Ref T13096. Adds an optional, disabled-by-default lock log to make it easier to figure out what is acquiring and holding locks.

Test Plan

Ran bin/lock log --enable, --disable, --name, etc. Saw sensible-looking output with log enabled and daemons restarted. Saw no additional output with log disabled and daemons restarted.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Draft.Mar 6 2018, 1:55 AM
This revision was automatically updated to reflect the committed changes.