Paths

Table of Contentst

Differential D19111

Tweak handling of "[[ / ]]" and "[x](y)" where "y" has parentheses
ClosedPublic
Actions

Authored by epriestley on Feb 16 2018, 7:05 PM.

Details

Reviewers: None
Maniphest Tasks: T12343: Link-Parsing fails if URL ends in ) when using "[name](link)" syntax
T13077: Plans: Phriction modern "v3" APIs, Drafts
Commits: rPHU9f49d4ed21f1: Tweak handling of "[[ / ]]" and "[x](y)" where "y" has parentheses

Summary

Ref T13077. Ref T12343.

[[ / ]] is better as a wiki root link than an install root link.
Let [x](y) work when y contains balanced, singly-nested parentheses.

Test Plan

Used both kinds of markup in documents, saw appropriate rendering

Diff Detail

Repository

rPHU libphutil

Branch

balance1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19600
Build 26533: Run Core Tests
Build 26532: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 16 2018, 7:05 PM

Harbormaster completed remote builds in B19600: Diff 45796.Feb 16 2018, 7:05 PM

epriestley requested review of this revision.Feb 16 2018, 7:05 PM

epriestley mentioned this in T12343: Link-Parsing fails if URL ends in ) when using "[name](link)" syntax.Feb 16 2018, 7:07 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 16 2018, 7:08 PM

Closed by commit rPHU9f49d4ed21f1: Tweak handling of "[[ / ]]" and "[x](y)" where "y" has parentheses (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

markup/

engine/

__tests__/

remarkup/

link-square.txt

6 lines

remarkup/

markuprule/

PhutilRemarkupDocumentLinkRule.php

32 lines

Diff 45796

View Options

src/markup/engine/tests/remarkup/link-square.txt

View Options

src/markup/engine/remarkup/markuprule/PhutilRemarkupDocumentLinkRule.php

Tweak handling of "[[ / ]]" and "[x](y)" where "y" has parenthesesClosedPublicActions