Fail outstanding buildables with aborted builds
ClosedPublic
Actions

Authored by epriestley on Feb 15 2018, 3:08 AM.

Details

Reviewers: None
Maniphest Tasks: T13072: Merge Harbormaster BuildCommand into BuildMessage
Commits: rP2b0f98900bcb: Fail outstanding buildables with aborted builds

Summary

Ref T13072. See PHI361. The bug in T10746 where aborting builds didn't propagate properly to the buildable was fixed, but existing builds are still stuck "Building".

Since it doesn't look like anything will moot this before these changes promote to stable, just migrate these builds into "failed".

Test Plan

Ran migration, saw it affect only relevant builds and correctly fail them.

Diff Detail

Repository

rP Phabricator

Branch

abort1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19560
Build 26472: Run Core Tests
Build 26471: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 15 2018, 3:08 AM

Harbormaster completed remote builds in B19560: Diff 45756.Feb 15 2018, 3:09 AM

epriestley requested review of this revision.Feb 15 2018, 3:09 AM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 15 2018, 11:57 AM

Closed by commit rP2b0f98900bcb: Fail outstanding buildables with aborted builds (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20180214.harbor.01.aborted.php

27 lines

Diff 45756

View Options

resources/sql/autopatches/20180214.harbor.01.aborted.php

Fail outstanding buildables with aborted buildsClosedPublicActions