Page MenuHomePhabricator
Differential D19090

Allow third-party code to extend upstream datasources via EngineExtension
ClosedPublic
Actions

Authored by epriestley on Feb 15 2018, 1:57 AM.
Tags
None
Referenced Files
F18809945: D19090.diff
Sun, Oct 19, 6:19 PM
F18809756: D19090.diff
Sun, Oct 19, 4:37 PM
F18788068: D19090.id45755.diff
Wed, Oct 15, 2:41 AM
F18742950: D19090.id.diff
Thu, Oct 2, 9:49 PM
F18740921: D19090.id45751.diff
Thu, Oct 2, 7:00 AM
F18736304: D19090.diff
Wed, Oct 1, 5:24 AM
F18509325: D19090.id.diff
Sep 5 2025, 3:21 AM
F18502175: D19090.diff
Sep 4 2025, 10:15 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13079: Allow third-party code to extend the list of functions that function datasources support
Commits
rPfe294d4034d7: Allow third-party code to extend upstream datasources via EngineExtension
Summary

Depends on D19089. Fixes T13079. This is likely not the final form of this, but creates a defensible extension point.

Test Plan

See T13079 for discussion.

Diff Detail

Repository
rP Phabricator
Branch
datasource4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19555
Build 26466: Run Core Tests
Build 26465: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 15 2018, 1:57 AM
Harbormaster completed remote builds in B19555: Diff 45751.Feb 15 2018, 1:58 AM
epriestley requested review of this revision.Feb 15 2018, 1:58 AM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 15 2018, 2:11 AM
Closed by commit rPfe294d4034d7: Allow third-party code to extend upstream datasources via EngineExtension (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
search/
engine/
18 lines
engineextension/
5 lines
typeahead/
datasource/
11 lines

Diff 45751

View Options

src/applications/search/engine/PhabricatorDatasourceEngine.php

Loading...
View Options

src/applications/search/engineextension/PhabricatorDatasourceEngineExtension.php

Loading...
View Options

src/applications/typeahead/datasource/PhabricatorTypeaheadCompositeDatasource.php

Loading...
Phabricator · Built by Phacility