Page MenuHomePhabricator

Modularize the "jump nav" behaviors in global search
ClosedPublic

Authored by epriestley on Feb 15 2018, 12:31 AM.
Tags
None
Referenced Files
F18756351: D19088.id.diff
Sun, Oct 5, 11:01 AM
F18739621: D19088.diff
Wed, Oct 1, 10:15 PM
F18650518: D19088.diff
Sun, Sep 21, 12:54 AM
F18509323: D19088.id.diff
Sep 5 2025, 3:21 AM
F18502173: D19088.diff
Sep 4 2025, 10:15 PM
F18442686: D19088.id.diff
Aug 31 2025, 5:36 PM
F18412901: D19088.diff
Aug 30 2025, 7:03 AM
F18102608: D19088.id45749.diff
Aug 9 2025, 10:02 PM
Subscribers
None

Details

Summary

Depends on D19087. Ref T13079. This still doesn't feel like the most clean, general system in the world, but is a step forward from hard-coded switch() stuff.

Test Plan
  • Jumped to r.
  • Jumped to a.
  • Jumped to r poe (multiple results).
  • Jumped to r poetry (one result).
  • Jumped to r syzygy (no results).
  • Jumped to p.
  • Jumped to p robot (multiple results); p assessment (one result).
    • The behavior for p <string> has changed slightly but should be more powerful now (it's consistent with r <string>).
  • Jumped to s <symbol> and s <context>-><symbol>.
  • Jumped to d.
  • Jumped to f.
  • Jumped to t.
  • Jumped to T123, D123, @dog, PHID-DREV-abcd, etc.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 15 2018, 2:08 AM
This revision was automatically updated to reflect the committed changes.