Page MenuHomePhabricator

Modularize the "jump nav" behaviors in global search
ClosedPublic

Authored by epriestley on Feb 15 2018, 12:31 AM.
Tags
None
Referenced Files
F15492161: D19088.id45749.diff
Sat, Apr 12, 11:47 AM
F15447224: D19088.id45749.diff
Thu, Mar 27, 10:36 PM
F15446802: D19088.id45753.diff
Thu, Mar 27, 8:22 PM
F15441756: D19088.id.diff
Wed, Mar 26, 7:44 PM
F15435480: D19088.diff
Tue, Mar 25, 8:31 AM
F15418165: D19088.id.diff
Thu, Mar 20, 9:15 PM
F15400935: D19088.diff
Mon, Mar 17, 2:48 PM
Unknown Object (File)
Feb 23 2025, 4:37 AM
Subscribers
None

Details

Summary

Depends on D19087. Ref T13079. This still doesn't feel like the most clean, general system in the world, but is a step forward from hard-coded switch() stuff.

Test Plan
  • Jumped to r.
  • Jumped to a.
  • Jumped to r poe (multiple results).
  • Jumped to r poetry (one result).
  • Jumped to r syzygy (no results).
  • Jumped to p.
  • Jumped to p robot (multiple results); p assessment (one result).
    • The behavior for p <string> has changed slightly but should be more powerful now (it's consistent with r <string>).
  • Jumped to s <symbol> and s <context>-><symbol>.
  • Jumped to d.
  • Jumped to f.
  • Jumped to t.
  • Jumped to T123, D123, @dog, PHID-DREV-abcd, etc.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 15 2018, 2:08 AM
This revision was automatically updated to reflect the committed changes.