Page MenuHomePhabricator

Add Editor-based mail stamps: actor, via, silent, encrypted, new, mention, self-actor, self-mention
ClosedPublic

Authored by epriestley on Feb 5 2018, 7:03 PM.
Tags
None
Referenced Files
F14760474: D18995.diff
Wed, Jan 22, 6:24 PM
Unknown Object (File)
Tue, Jan 21, 11:28 PM
Unknown Object (File)
Tue, Jan 21, 9:31 AM
Unknown Object (File)
Fri, Jan 17, 11:33 AM
Unknown Object (File)
Tue, Jan 14, 10:35 PM
Unknown Object (File)
Wed, Dec 25, 2:23 PM
Unknown Object (File)
Wed, Dec 25, 2:33 AM
Unknown Object (File)
Tue, Dec 24, 10:04 PM
Subscribers
None

Details

Summary

Ref T13053. Adds more mail tags with information available on the Editor object.

Test Plan

Banged around in Maniphest, viewed the resulting mail, all the stamps seemed to align with reality.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
204–206

Did this get picked up via a rebase?

This revision is now accepted and ready to land.Feb 5 2018, 10:58 PM
src/applications/transactions/engineextension/PhabricatorEditorMailEngineExtension.php
66

I added it so I could make the call here -- the flag was only internal with no getter before.

src/applications/transactions/engineextension/PhabricatorEditorMailEngineExtension.php
66

👍