Page MenuHomePhabricator

Add Editor-based mail stamps: actor, via, silent, encrypted, new, mention, self-actor, self-mention
ClosedPublic

Authored by epriestley on Feb 5 2018, 7:03 PM.
Tags
None
Referenced Files
F14845148: D18995.diff
Sun, Feb 2, 9:01 PM
Unknown Object (File)
Tue, Jan 28, 3:11 AM
Unknown Object (File)
Tue, Jan 28, 3:11 AM
Unknown Object (File)
Tue, Jan 28, 3:11 AM
Unknown Object (File)
Sun, Jan 26, 10:13 PM
Unknown Object (File)
Sat, Jan 25, 3:10 PM
Unknown Object (File)
Fri, Jan 24, 11:36 PM
Unknown Object (File)
Fri, Jan 24, 11:36 PM
Subscribers
None

Details

Summary

Ref T13053. Adds more mail tags with information available on the Editor object.

Test Plan

Banged around in Maniphest, viewed the resulting mail, all the stamps seemed to align with reality.

Diff Detail

Repository
rP Phabricator
Branch
stamps3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19341
Build 26147: Run Core Tests
Build 26146: arc lint + arc unit

Event Timeline

amckinley added inline comments.
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
204–206

Did this get picked up via a rebase?

This revision is now accepted and ready to land.Feb 5 2018, 10:58 PM
src/applications/transactions/engineextension/PhabricatorEditorMailEngineExtension.php
65

I added it so I could make the call here -- the flag was only internal with no getter before.

src/applications/transactions/engineextension/PhabricatorEditorMailEngineExtension.php
65

👍