Paths

Table of Contentst

Differential D18981

Escape glob characters for FileFinder's withSuffix() and withName()
ClosedPublic
Actions

Authored by epriestley on Jan 31 2018, 9:32 PM.

Details

Reviewers

amckinley

Commits

rPHUa7e21332c8fc: Escape glob characters for FileFinder's withSuffix() and withName()

Summary

Depends on D18980. When you search for files withSuffix('t*t'), that should match that suffix, literally, in a portable way.

Test Plan

Added unit tests and made them pass.

Diff Detail

Repository

rPHU libphutil

Branch

finder3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19305
Build 26092: Run Core Tests
Build 26091: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 31 2018, 9:32 PM

Create a temporary directory and write all the glob garbage to it instead.

Harbormaster completed remote builds in B19305: Diff 45516.Jan 31 2018, 9:37 PM

epriestley requested review of this revision.Jan 31 2018, 9:37 PM

epriestley edited the summary of this revision. (Show Details)Jan 31 2018, 9:37 PM

amckinley accepted this revision.Jan 31 2018, 10:02 PM

amckinley added inline comments.

src/filesystem/__tests__/FileFinderTestCase.php
128–130

This revision is now accepted and ready to land.Jan 31 2018, 10:02 PM

epriestley added a child revision: D18982: Add withNameGlob() to FileFinder.Jan 31 2018, 10:38 PM

Closed by commit rPHUa7e21332c8fc: Escape glob characters for FileFinder's withSuffix() and withName() (authored by epriestley). · Explain WhyJan 31 2018, 11:29 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

filesystem/

FileFinder.php

36 lines

__tests__/

FileFinderTestCase.php

70 lines

Diff 45516

View Options

src/filesystem/FileFinder.php

View Options

src/filesystem/tests/FileFinderTestCase.php

Escape glob characters for FileFinder's withSuffix() and withName()ClosedPublicActions