Page MenuHomePhabricator
Differential D18981

Escape glob characters for FileFinder's withSuffix() and withName()
ClosedPublic
Actions

Authored by epriestley on Jan 31 2018, 9:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 5:11 AM
Unknown Object (File)
Sun, Feb 9, 5:10 AM
Unknown Object (File)
Sun, Feb 9, 5:10 AM
Unknown Object (File)
Sun, Feb 9, 5:10 AM
Unknown Object (File)
Fri, Jan 31, 4:56 AM
Unknown Object (File)
Fri, Jan 24, 11:33 PM
Unknown Object (File)
Fri, Jan 24, 11:32 PM
Unknown Object (File)
Fri, Jan 24, 11:32 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rPHUa7e21332c8fc: Escape glob characters for FileFinder's withSuffix() and withName()
Summary

Depends on D18980. When you search for files withSuffix('t*t'), that should match that suffix, literally, in a portable way.

Test Plan

Added unit tests and made them pass.

Diff Detail

Repository
rPHU libphutil
Branch
finder3
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/filesystem/__tests__/glob-magic/star-*.*:NAME1Bad Filename
Errorsrc/filesystem/__tests__/glob-magic/star-*.txt:NAME1Bad Filename
Errorsrc/filesystem/__tests__/glob-magic/star.t*t:NAME1Bad Filename
Unit
Tests Passed
Build Status
Buildable 19304
Build 26090: Run Core Tests
Build 26089: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 31 2018, 9:32 PM
epriestley updated this revision to Diff 45516.Jan 31 2018, 9:36 PM
  • Create a temporary directory and write all the glob garbage to it instead.
Harbormaster completed remote builds in B19305: Diff 45516.Jan 31 2018, 9:37 PM
epriestley requested review of this revision.Jan 31 2018, 9:37 PM
epriestley edited the summary of this revision. (Show Details)Jan 31 2018, 9:37 PM
amckinley accepted this revision.Jan 31 2018, 10:02 PM
amckinley added inline comments.
src/filesystem/__tests__/FileFinderTestCase.php
124–126

thumbsup.gif (320×300 px, 6 MB)

This revision is now accepted and ready to land.Jan 31 2018, 10:02 PM
epriestley added a child revision: D18982: Add withNameGlob() to FileFinder.Jan 31 2018, 10:38 PM
Closed by commit rPHUa7e21332c8fc: Escape glob characters for FileFinder's withSuffix() and withName() (authored by epriestley). · Explain WhyJan 31 2018, 11:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
filesystem/
36 lines
__tests__/
50 lines
glob-magic/
1 line
1 line
1 line
1 line
1 line

Diff 45515

View Options

src/filesystem/FileFinder.php

Loading...
View Options

src/filesystem/__tests__/FileFinderTestCase.php

Loading...
View Options

src/filesystem/__tests__/glob-magic/backslash\.\*

Loading...
View Options

src/filesystem/__tests__/glob-magic/star-*.*

Loading...
View Options

src/filesystem/__tests__/glob-magic/star-*.txt

Loading...
View Options

src/filesystem/__tests__/glob-magic/star.t*t

Loading...
View Options

src/filesystem/__tests__/glob-magic/star.tesseract

Loading...
Phabricator · Built by Phacility