Remove the caret dropdown from transaction lists when no actions are available
ClosedPublic
Actions

Authored by epriestley on Jan 29 2018, 8:56 PM.

Details

Reviewers

Commits

rP40e9806e3c88: Remove the caret dropdown from transaction lists when no actions are available

Summary

See PHI325. When a transaction group in Differential (or Pholio) only has an inline comment, it renders with a "V" caret but no actual dropdown menu.

This caret renders in a "disabled" color, but the color is "kinda grey". The "active" color is "kinda grey with a dab of blue". Here's what they look like today:

Screen Shot 2018-01-29 at 12.43.26 PM.png (170×69 px, 4 KB)

Just remove it.

Test Plan

Viewed one of these, no longer saw the inactive caret.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 29 2018, 8:56 PM

Harbormaster completed remote builds in B19252: Diff 45468.Jan 29 2018, 8:57 PM

epriestley requested review of this revision.Jan 29 2018, 8:57 PM

amckinley accepted this revision.Jan 29 2018, 9:38 PM

This revision is now accepted and ready to land.Jan 29 2018, 9:38 PM

Just remove it completely.

Harbormaster completed remote builds in B19255: Diff 45471.Jan 29 2018, 10:17 PM

epriestley retitled this revision from Make the "disabled" state for the transaction dropdown menu more clear to Remove the caret dropdown from transaction lists when no actions are available.Jan 29 2018, 10:43 PM

epriestley edited the summary of this revision. (Show Details)

epriestley edited the test plan for this revision. (Show Details)

I changed this to just nuke it instead so it now bears little relation to the earlier change.

src/view/phui/PHUITimelineEventView.php
308–310	This blames to D8966 and it looks like I was just trying to always show a menu, which is broadly consistent with how we treat this in other applications. So I think removing this is likely safe and doesn't have any far-reaching implications.