Page MenuHomePhabricator

Remove the caret dropdown from transaction lists when no actions are available
ClosedPublic

Authored by epriestley on Jan 29 2018, 8:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 12:46 AM
Unknown Object (File)
Thu, Apr 18, 5:39 AM
Unknown Object (File)
Wed, Apr 17, 4:40 PM
Unknown Object (File)
Sun, Apr 14, 1:27 PM
Unknown Object (File)
Sun, Apr 14, 9:32 AM
Unknown Object (File)
Thu, Apr 11, 9:29 PM
Unknown Object (File)
Thu, Apr 11, 7:29 PM
Unknown Object (File)
Thu, Apr 4, 6:02 PM
Subscribers
None

Details

Summary

See PHI325. When a transaction group in Differential (or Pholio) only has an inline comment, it renders with a "V" caret but no actual dropdown menu.

This caret renders in a "disabled" color, but the color is "kinda grey". The "active" color is "kinda grey with a dab of blue". Here's what they look like today:

Screen Shot 2018-01-29 at 12.43.26 PM.png (170×69 px, 4 KB)

Just remove it.

Test Plan

Viewed one of these, no longer saw the inactive caret.

Diff Detail

Repository
rP Phabricator
Branch
css-contrast
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19252
Build 26016: Run Core Tests
Build 26015: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jan 29 2018, 9:38 PM
epriestley retitled this revision from Make the "disabled" state for the transaction dropdown menu more clear to Remove the caret dropdown from transaction lists when no actions are available.Jan 29 2018, 10:43 PM
epriestley edited the summary of this revision. (Show Details)
epriestley edited the test plan for this revision. (Show Details)

I changed this to just nuke it instead so it now bears little relation to the earlier change.

src/view/phui/PHUITimelineEventView.php
308–310 ↗(On Diff #45471)

This blames to D8966 and it looks like I was just trying to always show a menu, which is broadly consistent with how we treat this in other applications. So I think removing this is likely safe and doesn't have any far-reaching implications.

This revision is now accepted and ready to land.Jan 29 2018, 11:10 PM
This revision was automatically updated to reflect the committed changes.