Modernize "PhabricatorRepositoryPushEventQuery"
ClosedPublic
Actions

Authored by epriestley on Jan 23 2018, 4:09 PM.

Tags

None

Referenced Files

	F14124414: D18915.diff
	Sat, Nov 30, 3:02 AM

	Unknown Object (File)
	Thu, Nov 28, 1:28 AM

	Unknown Object (File)
	Tue, Nov 19, 8:13 PM

	Unknown Object (File)
	Sat, Nov 16, 1:24 PM

	Unknown Object (File)
	Tue, Nov 12, 10:31 AM

	Unknown Object (File)
	Sat, Nov 9, 2:54 PM

	Unknown Object (File)
	Sat, Nov 9, 2:54 PM

	Unknown Object (File)
	Sat, Nov 9, 2:54 PM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rPa6fbde784c71: Modernize "PhabricatorRepositoryPushEventQuery"

Summary

Depends on D18914. Updates this Query to use slightly more modern construction while I'm working in adjacent code.

Test Plan

Viewed push logs in web UI.

Diff Detail

Repository

rP Phabricator

Branch

pull3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19133
Build 25835: Run Core Tests
Build 25834: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 23 2018, 4:09 PM

Harbormaster completed remote builds in B19133: Diff 45346.Jan 23 2018, 4:10 PM

epriestley requested review of this revision.Jan 23 2018, 4:10 PM

epriestley added a child revision: D18917: Make minor correctness and display improvements to pull logs.Jan 23 2018, 4:28 PM

amckinley accepted this revision.Jan 23 2018, 9:04 PM

This revision is now accepted and ready to land.Jan 23 2018, 9:04 PM

Closed by commit rPa6fbde784c71: Modernize "PhabricatorRepositoryPushEventQuery" (authored by epriestley). · Explain WhyJan 23 2018, 10:12 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

query/

PhabricatorRepositoryPushEventQuery.php

41 lines

Diff 45346

View Options

src/applications/repository/query/PhabricatorRepositoryPushEventQuery.php

Modernize "PhabricatorRepositoryPushEventQuery"ClosedPublicActions