Page MenuHomePhabricator

Add test coverage to the PasswordEngine upgrade workflow and fix a few bugs
ClosedPublic

Authored by epriestley on Jan 21 2018, 3:44 PM.
Tags
None
Referenced Files
F18993054: D18897.id45313.diff
Wed, Nov 19, 5:26 AM
F18886571: D18897.id45313.diff
Fri, Nov 7, 4:35 AM
F18886507: D18897.diff
Fri, Nov 7, 4:29 AM
F18844417: D18897.id45353.diff
Wed, Oct 29, 5:15 AM
F18841924: D18897.id.diff
Tue, Oct 28, 12:17 PM
F18837467: D18897.diff
Oct 27 2025, 5:36 AM
F18835373: D18897.id45312.diff
Oct 26 2025, 3:28 PM
F18811535: D18897.id45353.diff
Oct 20 2025, 3:52 AM
Subscribers
None

Details

Summary

Ref T13043. When we verify a password and a better hasher is available, we automatically upgrade the stored hash to the stronger hasher.

Add test coverage for this workflow and fix a few bugs and issues, mostly related to shuffling the old hasher name into the transaction.

This doesn't touch anything user-visible yet.

Test Plan

Ran unit tests.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable