Page MenuHomePhabricator

Add test coverage to the PasswordEngine upgrade workflow and fix a few bugs
ClosedPublic

Authored by epriestley on Jan 21 2018, 3:44 PM.
Tags
None
Referenced Files
F15429100: D18897.id45313.diff
Mon, Mar 24, 12:34 AM
F15424150: D18897.id45313.diff
Sat, Mar 22, 8:33 PM
F15423628: D18897.id45312.diff
Sat, Mar 22, 4:21 PM
F15416770: D18897.id.diff
Thu, Mar 20, 1:21 PM
F15409957: D18897.diff
Wed, Mar 19, 6:08 AM
F15409356: D18897.id45312.diff
Wed, Mar 19, 4:25 AM
Unknown Object (File)
Tue, Feb 25, 5:33 AM
Unknown Object (File)
Mon, Feb 24, 1:04 AM
Subscribers
None

Details

Summary

Ref T13043. When we verify a password and a better hasher is available, we automatically upgrade the stored hash to the stronger hasher.

Add test coverage for this workflow and fix a few bugs and issues, mostly related to shuffling the old hasher name into the transaction.

This doesn't touch anything user-visible yet.

Test Plan

Ran unit tests.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable