Page MenuHomePhabricator

Add test coverage to the PasswordEngine upgrade workflow and fix a few bugs
ClosedPublic

Authored by epriestley on Jan 21 2018, 3:44 PM.
Tags
None
Referenced Files
F19544026: D18897.diff
Fri, Jan 23, 2:15 AM
F19508797: D18897.diff
Sat, Jan 10, 10:40 AM
F19061301: D18897.id.diff
Nov 29 2025, 11:59 AM
F19052536: D18897.diff
Nov 28 2025, 5:18 AM
F18993054: D18897.id45313.diff
Nov 19 2025, 5:26 AM
F18886571: D18897.id45313.diff
Nov 7 2025, 4:35 AM
F18886507: D18897.diff
Nov 7 2025, 4:29 AM
F18844417: D18897.id45353.diff
Oct 29 2025, 5:15 AM
Subscribers
None

Details

Summary

Ref T13043. When we verify a password and a better hasher is available, we automatically upgrade the stored hash to the stronger hasher.

Add test coverage for this workflow and fix a few bugs and issues, mostly related to shuffling the old hasher name into the transaction.

This doesn't touch anything user-visible yet.

Test Plan

Ran unit tests.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable