Page MenuHomePhabricator

Add test coverage to the PasswordEngine upgrade workflow and fix a few bugs
ClosedPublic

Authored by epriestley on Jan 21 2018, 3:44 PM.
Tags
None
Referenced Files
F17627602: D18897.id45313.diff
Thu, Jul 10, 6:34 AM
F17607316: D18897.diff
Wed, Jul 9, 3:17 AM
Unknown Object (File)
Tue, Jul 1, 9:26 AM
Unknown Object (File)
Tue, Jul 1, 8:15 AM
Unknown Object (File)
Mon, Jun 30, 3:54 AM
Unknown Object (File)
Sun, Jun 29, 11:50 PM
Unknown Object (File)
Sun, Jun 29, 5:05 AM
Unknown Object (File)
Fri, Jun 27, 5:24 PM
Subscribers
None

Details

Summary

Ref T13043. When we verify a password and a better hasher is available, we automatically upgrade the stored hash to the stronger hasher.

Add test coverage for this workflow and fix a few bugs and issues, mostly related to shuffling the old hasher name into the transaction.

This doesn't touch anything user-visible yet.

Test Plan

Ran unit tests.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable