Page MenuHomePhabricator

Add test coverage to the PasswordEngine upgrade workflow and fix a few bugs
ClosedPublic

Authored by epriestley on Jan 21 2018, 3:44 PM.
Tags
None
Referenced Files
F15525525: D18897.id45353.diff
Mon, Apr 21, 3:05 PM
F15521178: D18897.id.diff
Sun, Apr 20, 11:52 AM
F15498782: D18897.id45353.diff
Sun, Apr 13, 2:14 PM
F15471672: D18897.id45313.diff
Sat, Apr 5, 7:08 AM
F15471123: D18897.id45353.diff
Sat, Apr 5, 3:23 AM
F15455570: D18897.diff
Sun, Mar 30, 3:17 AM
F15429100: D18897.id45313.diff
Mar 24 2025, 12:34 AM
F15424150: D18897.id45313.diff
Mar 22 2025, 8:33 PM
Subscribers
None

Details

Summary

Ref T13043. When we verify a password and a better hasher is available, we automatically upgrade the stored hash to the stronger hasher.

Add test coverage for this workflow and fix a few bugs and issues, mostly related to shuffling the old hasher name into the transaction.

This doesn't touch anything user-visible yet.

Test Plan

Ran unit tests.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable