Page MenuHomePhabricator

Add test coverage to the PasswordEngine upgrade workflow and fix a few bugs
ClosedPublic

Authored by epriestley on Jan 21 2018, 3:44 PM.

Details

Summary

Ref T13043. When we verify a password and a better hasher is available, we automatically upgrade the stored hash to the stronger hasher.

Add test coverage for this workflow and fix a few bugs and issues, mostly related to shuffling the old hasher name into the transaction.

This doesn't touch anything user-visible yet.

Test Plan

Ran unit tests.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jan 21 2018, 3:44 PM
epriestley requested review of this revision.Jan 21 2018, 3:45 PM
epriestley updated this revision to Diff 45313.Jan 21 2018, 3:46 PM
  • Very slightly smaller diff.
amckinley accepted this revision.Jan 23 2018, 2:51 AM
This revision is now accepted and ready to land.Jan 23 2018, 2:51 AM
This revision was automatically updated to reflect the committed changes.