Page MenuHomePhabricator

Respect token limits for "Assign to" and custom datasource fields in Herald
ClosedPublic

Authored by epriestley on Jan 19 2018, 10:46 PM.
Tags
None
Referenced Files
F13133929: D18887.diff
Thu, May 2, 12:15 AM
Unknown Object (File)
Thu, Apr 25, 1:22 AM
Unknown Object (File)
Sun, Apr 21, 9:39 PM
Unknown Object (File)
Wed, Apr 17, 7:08 PM
Unknown Object (File)
Wed, Apr 17, 2:09 AM
Unknown Object (File)
Sun, Apr 7, 5:46 PM
Unknown Object (File)
Thu, Apr 4, 3:14 AM
Unknown Object (File)
Tue, Apr 2, 4:44 PM
Subscribers
None

Details

Summary

See PHI173. Currently, Herald has an "Assign to" action for tasks, and you can specify custom fields with datasource values (like users or projects) that have a limit (like 1 "Owner", or 12 "Jury Members").

Herald doesn't support these limits right now, so you can write [ Assign to ][ X, Y, Z ]. This just means "Assign to X", but make it more clear by actually enforcing the limit in the UI.

Test Plan
  • Created a "projects" custom field with limit 1.
  • Tried to create actions that 'assign to' or 'set custom field to' more than one thing, got helpfully rebuffed by the UI.
  • Created an "add subscribers" action with more than one value.

Diff Detail

Repository
rP Phabricator
Branch
limit1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19086
Build 25755: Run Core Tests
Build 25754: arc lint + arc unit