Page MenuHomePhabricator

Respect token limits for "Assign to" and custom datasource fields in Herald
ClosedPublic

Authored by epriestley on Jan 19 2018, 10:46 PM.
Tags
None
Referenced Files
F19532420: D18887.id45333.diff
Jan 20 2026, 10:48 AM
F19507888: D18887.id45333.diff
Jan 9 2026, 11:55 PM
F19507887: D18887.id45299.diff
Jan 9 2026, 11:55 PM
F19507886: D18887.id.diff
Jan 9 2026, 11:55 PM
F19013393: D18887.id.diff
Nov 22 2025, 3:22 PM
F19002853: D18887.diff
Nov 21 2025, 7:02 AM
F18906392: D18887.id45333.diff
Nov 8 2025, 6:13 PM
F18837706: D18887.diff
Oct 27 2025, 7:24 AM
Subscribers
None

Details

Summary

See PHI173. Currently, Herald has an "Assign to" action for tasks, and you can specify custom fields with datasource values (like users or projects) that have a limit (like 1 "Owner", or 12 "Jury Members").

Herald doesn't support these limits right now, so you can write [ Assign to ][ X, Y, Z ]. This just means "Assign to X", but make it more clear by actually enforcing the limit in the UI.

Test Plan
  • Created a "projects" custom field with limit 1.
  • Tried to create actions that 'assign to' or 'set custom field to' more than one thing, got helpfully rebuffed by the UI.
  • Created an "add subscribers" action with more than one value.

Diff Detail

Repository
rP Phabricator
Branch
limit1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19086
Build 25755: Run Core Tests
Build 25754: arc lint + arc unit