Page MenuHomePhabricator

Respect token limits for "Assign to" and custom datasource fields in Herald
ClosedPublic

Authored by epriestley on Jan 19 2018, 10:46 PM.
Tags
None
Referenced Files
F15345593: D18887.diff
Mon, Mar 10, 11:35 AM
Unknown Object (File)
Feb 10 2025, 4:36 AM
Unknown Object (File)
Feb 9 2025, 4:57 AM
Unknown Object (File)
Feb 9 2025, 4:57 AM
Unknown Object (File)
Feb 9 2025, 4:57 AM
Unknown Object (File)
Feb 9 2025, 4:57 AM
Unknown Object (File)
Jan 31 2025, 10:59 PM
Unknown Object (File)
Jan 29 2025, 3:50 PM
Subscribers
None

Details

Summary

See PHI173. Currently, Herald has an "Assign to" action for tasks, and you can specify custom fields with datasource values (like users or projects) that have a limit (like 1 "Owner", or 12 "Jury Members").

Herald doesn't support these limits right now, so you can write [ Assign to ][ X, Y, Z ]. This just means "Assign to X", but make it more clear by actually enforcing the limit in the UI.

Test Plan
  • Created a "projects" custom field with limit 1.
  • Tried to create actions that 'assign to' or 'set custom field to' more than one thing, got helpfully rebuffed by the UI.
  • Created an "add subscribers" action with more than one value.

Diff Detail

Repository
rP Phabricator
Branch
limit1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19086
Build 25755: Run Core Tests
Build 25754: arc lint + arc unit