Fix a transposed feed story in Badges
ClosedPublic
Actions

Authored by epriestley on Jan 16 2018, 7:03 PM.

Tags

None

Referenced Files

	F18198109: D18870.id45259.diff
	Sun, Aug 17, 10:42 PM

	F18109505: D18870.id45258.diff
	Mon, Aug 11, 2:11 PM

	F18107347: D18870.id.diff
	Mon, Aug 11, 12:26 AM

	F18105803: D18870.id45259.diff
	Sun, Aug 10, 7:47 PM

	F18102118: D18870.diff
	Sat, Aug 9, 6:17 PM

	F17711925: D18870.diff
	Jul 17 2025, 9:19 AM

	Unknown Object (File)
	May 20 2025, 3:07 PM

	Unknown Object (File)
	May 4 2025, 5:29 PM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rP3e983b583dc0: Fix a transposed feed story in Badges

Summary

See https://discourse.phabricator-community.org/t/badge-quality-from-and-to-interchanged-in-activity-log/987. These are swapped.

Test Plan

Changed a badge quality, viewed feed story, saw it position the strings correctly.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 16 2018, 7:03 PM

Harbormaster completed remote builds in B19040: Diff 45258.Jan 16 2018, 7:04 PM

epriestley requested review of this revision.Jan 16 2018, 7:04 PM

I'm also not really sure this string is grammatical English.

Make the grammar a bit smoother?

Harbormaster completed remote builds in B19041: Diff 45259.Jan 16 2018, 7:09 PM

amckinley accepted this revision.Jan 16 2018, 9:26 PM

This revision is now accepted and ready to land.Jan 16 2018, 9:26 PM

Closed by commit rP3e983b583dc0: Fix a transposed feed story in Badges (authored by epriestley). · Explain WhyJan 16 2018, 9:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

badges/

xaction/

PhabricatorBadgesBadgeQualityTransaction.php

6 lines

Diff 45260

View Options

src/applications/badges/xaction/PhabricatorBadgesBadgeQualityTransaction.php

Fix a transposed feed story in BadgesClosedPublicActions