Fix a transposed feed story in Badges
ClosedPublic
Actions

Authored by epriestley on Jan 16 2018, 7:03 PM.

Tags

None

Referenced Files

	F19276950: D18870.diff
	Tue, Dec 23, 1:29 AM

	F19049661: D18870.diff
	Thu, Nov 27, 5:55 PM

	F18836095: D18870.id.diff
	Oct 26 2025, 10:00 PM

	F18831925: D18870.diff
	Oct 25 2025, 5:00 PM

	F18773128: D18870.diff
	Oct 9 2025, 7:24 AM

	F18750990: D18870.id45258.diff
	Oct 4 2025, 9:29 AM

	F18509233: D18870.id.diff
	Sep 5 2025, 3:18 AM

	F18501944: D18870.diff
	Sep 4 2025, 10:04 PM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rP3e983b583dc0: Fix a transposed feed story in Badges

Summary

See https://discourse.phabricator-community.org/t/badge-quality-from-and-to-interchanged-in-activity-log/987. These are swapped.

Test Plan

Changed a badge quality, viewed feed story, saw it position the strings correctly.

Diff Detail

Repository

rP Phabricator

Branch

badge1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19040
Build 25691: Run Core Tests
Build 25690: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 16 2018, 7:03 PM

Harbormaster completed remote builds in B19040: Diff 45258.Jan 16 2018, 7:04 PM

epriestley requested review of this revision.Jan 16 2018, 7:04 PM

I'm also not really sure this string is grammatical English.

Make the grammar a bit smoother?

Harbormaster completed remote builds in B19041: Diff 45259.Jan 16 2018, 7:09 PM

amckinley accepted this revision.Jan 16 2018, 9:26 PM

This revision is now accepted and ready to land.Jan 16 2018, 9:26 PM

Closed by commit rP3e983b583dc0: Fix a transposed feed story in Badges (authored by epriestley). · Explain WhyJan 16 2018, 9:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

badges/

xaction/

PhabricatorBadgesBadgeQualityTransaction.php

4 lines

Diff 45258

View Options

src/applications/badges/xaction/PhabricatorBadgesBadgeQualityTransaction.php

Fix a transposed feed story in BadgesClosedPublicActions