Fix a transposed feed story in Badges
ClosedPublic
Actions

Authored by epriestley on Jan 16 2018, 7:03 PM.

Tags

None

Referenced Files

	F15538867: D18870.id.diff
	Thu, Apr 24, 9:59 PM

	F15538256: D18870.id45259.diff
	Thu, Apr 24, 6:17 PM

	F15532575: D18870.diff
	Wed, Apr 23, 4:25 PM

	F15516658: D18870.id45259.diff
	Fri, Apr 18, 8:21 PM

	F15428782: D18870.diff
	Mar 23 2025, 10:17 PM

	F15407878: D18870.id45260.diff
	Mar 18 2025, 8:00 PM

	F15375840: D18870.diff
	Mar 13 2025, 12:22 AM

	Unknown Object (File)
	Feb 27 2025, 10:41 PM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rP3e983b583dc0: Fix a transposed feed story in Badges

Summary

See https://discourse.phabricator-community.org/t/badge-quality-from-and-to-interchanged-in-activity-log/987. These are swapped.

Test Plan

Changed a badge quality, viewed feed story, saw it position the strings correctly.

Diff Detail

Repository

rP Phabricator

Branch

badge1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19040
Build 25691: Run Core Tests
Build 25690: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 16 2018, 7:03 PM

Harbormaster completed remote builds in B19040: Diff 45258.Jan 16 2018, 7:04 PM

epriestley requested review of this revision.Jan 16 2018, 7:04 PM

I'm also not really sure this string is grammatical English.

Make the grammar a bit smoother?

Harbormaster completed remote builds in B19041: Diff 45259.Jan 16 2018, 7:09 PM

amckinley accepted this revision.Jan 16 2018, 9:26 PM

This revision is now accepted and ready to land.Jan 16 2018, 9:26 PM

Closed by commit rP3e983b583dc0: Fix a transposed feed story in Badges (authored by epriestley). · Explain WhyJan 16 2018, 9:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

badges/

xaction/

PhabricatorBadgesBadgeQualityTransaction.php

4 lines

Diff 45258

View Options

src/applications/badges/xaction/PhabricatorBadgesBadgeQualityTransaction.php

Fix a transposed feed story in BadgesClosedPublicActions