Fix a transposed feed story in Badges
ClosedPublic
Actions

Authored by epriestley on Jan 16 2018, 7:03 PM.

Tags

None

Referenced Files

	F13245913: D18870.id45260.diff
	Thu, May 23, 6:34 AM

	F13229384: D18870.id45258.diff
	Mon, May 20, 4:10 PM

	F13227032: D18870.diff
	Mon, May 20, 12:51 AM

	F13221657: D18870.diff
	Sun, May 19, 2:56 AM

	F13204125: D18870.diff
	Wed, May 15, 12:21 AM

	F13186920: D18870.diff
	Sat, May 11, 4:12 AM

	Unknown Object (File)
	Tue, May 7, 7:17 AM

	Unknown Object (File)
	Fri, May 3, 5:45 AM

View All 81 Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rP3e983b583dc0: Fix a transposed feed story in Badges

Summary

See https://discourse.phabricator-community.org/t/badge-quality-from-and-to-interchanged-in-activity-log/987. These are swapped.

Test Plan

Changed a badge quality, viewed feed story, saw it position the strings correctly.

Diff Detail

Repository

rP Phabricator

Branch

badge1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19040
Build 25691: Run Core Tests
Build 25690: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 16 2018, 7:03 PM

Harbormaster completed remote builds in B19040: Diff 45258.Jan 16 2018, 7:04 PM

epriestley requested review of this revision.Jan 16 2018, 7:04 PM

I'm also not really sure this string is grammatical English.

Make the grammar a bit smoother?

Harbormaster completed remote builds in B19041: Diff 45259.Jan 16 2018, 7:09 PM

amckinley accepted this revision.Jan 16 2018, 9:26 PM

This revision is now accepted and ready to land.Jan 16 2018, 9:26 PM

Closed by commit rP3e983b583dc0: Fix a transposed feed story in Badges (authored by epriestley). · Explain WhyJan 16 2018, 9:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

badges/

xaction/

PhabricatorBadgesBadgeQualityTransaction.php

4 lines

Diff 45258

View Options

src/applications/badges/xaction/PhabricatorBadgesBadgeQualityTransaction.php

Fix a transposed feed story in BadgesClosedPublicActions