Page MenuHomePhabricator

Add an "Accepting reviewers" Herald field for commits
ClosedPublic

Authored by epriestley on Dec 22 2017, 6:19 PM.
Tags
None
Referenced Files
F13062509: D18839.diff
Sat, Apr 20, 12:26 AM
Unknown Object (File)
Fri, Apr 19, 2:43 AM
Unknown Object (File)
Thu, Apr 4, 11:58 PM
Unknown Object (File)
Tue, Apr 2, 4:42 PM
Unknown Object (File)
Tue, Apr 2, 4:42 PM
Unknown Object (File)
Tue, Apr 2, 4:42 PM
Unknown Object (File)
Mar 10 2024, 6:12 AM
Unknown Object (File)
Feb 3 2024, 5:21 PM
Subscribers
None

Details

Summary

See PHI262. Fixes T12578. Although this is a bit niche and probably better accomplished through advisory/soft measures ("Add blocking reviewers") in most cases, it isn't difficult to implement and doesn't create any technical or product tension.

If installs write a rule that blocks commits, that will probably also naturally lead them to an "add reviewers" rule anyway.

Also, allow packages to be hit with the typeahead. They're valid reviewers but previously you couldn't write rules against them, for no actual reason.

Test Plan

Used test console to run this against commits, got sensible results for the field value.

Diff Detail

Repository
rP Phabricator
Branch
reviewer1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18973
Build 25591: Run Core Tests
Build 25590: arc lint + arc unit